RESOLVED FIXED Bug 86349
Web Inspector: Esc should revert the colorpicker-modifed color to the original 
https://bugs.webkit.org/show_bug.cgi?id=86349
Summary Web Inspector: Esc should revert the colorpicker-modifed color to the original
Alexander Pavlov (apavlov)
Reported 2012-05-14 03:23:16 PDT
1. Start editing color 2. Make an accidental modification 3. Hit Esc to cancel editing Expected: editing canceled Actual: editing persisted. Upstreaming http://code.google.com/p/chromium/issues/detail?id=128010
Attachments
Patch (4.64 KB, patch)
2012-05-14 03:28 PDT, Alexander Pavlov (apavlov) 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2012-05-14 03:28:54 PDT
Created attachment 141679 [details] Patch
Vsevolod Vlasov
Comment 2 2012-05-14 04:19:58 PDT
Comment on attachment 141679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141679&action=review > Source/WebCore/inspector/front-end/Spectrum.js:422 > + this.dispatchEventToListeners(WebInspector.Spectrum.Events.Hidden, !!cancelEdit); Maybe invert this value? > Source/WebCore/inspector/front-end/Spectrum.js:433 > + this.hide(event.keyIdentifier === "U+001B"); Maybe use two ifs?
Alexander Pavlov (apavlov)
Comment 3 2012-05-14 04:41:23 PDT
Committed r116933: <http://trac.webkit.org/changeset/116933>
Note You need to log in before you can comment on or make changes to this bug.