Bug 86346 - [chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
Summary: [chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks: 80400
  Show dependency tree / graph
 
Reported: 2012-05-14 02:18 PDT by noel gordon
Modified: 2012-05-16 15:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.19 KB, patch)
2012-05-14 02:20 PDT, noel gordon 		no flags Details | Formatted Diff | Diff
Patch (9.94 KB, patch)
2012-05-15 02:12 PDT, noel gordon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-05-14 02:18:45 PDT 
[chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
Comment 1 noel gordon 2012-05-14 02:20:54 PDT 
Created attachment 141669 [details]
Patch
Comment 2 noel gordon 2012-05-14 21:17:39 PDT 
Well nothing exploded :)  Perhaps I should also remove the ImageSource changes, thoughts?

http://trac.webkit.org/changeset/70846/trunk/WebCore/platform/graphics/ImageSource.h
Comment 3 noel gordon 2012-05-15 02:11:32 PDT 
Suppose I could just try removing ImageSource changes ...
Comment 4 noel gordon 2012-05-15 02:12:29 PDT 
Created attachment 141896 [details]
Patch
Comment 5 Peter Kasting 2012-05-15 11:14:53 PDT 
Not a reviewer, but LGTM
Comment 6 Adam Barth 2012-05-15 11:20:01 PDT 
Thanks Noel!
Comment 7 noel gordon 2012-05-15 16:08:12 PDT 
This code served us well Adam, thanks for writing it. @zoltan, this change will bump your work on bug 80400, may I continue?
Comment 8 Zoltan Horvath 2012-05-16 10:03:09 PDT 
Thanks for your notice Noel!

It does not affect too much on my actual patch, so let's check it in. I'll update my (bug #80400) patch later, since I have to find a solution for jpeglib/pnglib qt-mac dependency.
Comment 9 noel gordon 2012-05-16 14:51:44 PDT 
Ok Zoltan thank you, I'll go ahead and submit.
Comment 10 WebKit Review Bot 2012-05-16 15:36:54 PDT 
Comment on attachment 141896 [details]
Patch

Clearing flags on attachment: 141896

Committed r117355: <http://trac.webkit.org/changeset/117355>
Comment 11 WebKit Review Bot 2012-05-16 15:36:59 PDT 
All reviewed patches have been landed.  Closing bug.