Bug 86338 - Introduce ENABLE_CSS_VARIABLES compile flag.
Summary: Introduce ENABLE_CSS_VARIABLES compile flag.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks: 85580
  Show dependency treegraph
 
Reported: 2012-05-13 23:50 PDT by Luke Macpherson
Modified: 2012-07-03 17:19 PDT (History)
10 users (show)

See Also:


Attachments
Patch (24.51 KB, patch)
2012-05-13 23:56 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff
Patch (2.31 KB, patch)
2012-05-15 00:07 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-05-13 23:50:48 PDT
Introduce ENABLE_CSS_VARIABLES compile flag.
Comment 1 Luke Macpherson 2012-05-13 23:56:00 PDT
Created attachment 141652 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-05-14 09:06:49 PDT
Comment on attachment 141652 [details]
Patch

I believe you're still missing the changes to vsprops files for Windows builds. You can land them as a separate patch.
Comment 3 Luke Macpherson 2012-05-14 16:22:04 PDT
Ok, I'll follow up with the windows changes. Thanks.
Comment 4 WebKit Review Bot 2012-05-14 17:23:40 PDT
Comment on attachment 141652 [details]
Patch

Rejecting attachment 141652 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
org/svn/trunk/src/webkit@136942
    parsed_url: http://src.chromium.org/svn/trunk/src/webkit@136942
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)

Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at Tools/Scripts/update-webkit line 118.

Full output: http://queues.webkit.org/results/12685495
Comment 5 WebKit Review Bot 2012-05-14 21:38:25 PDT
Comment on attachment 141652 [details]
Patch

Clearing flags on attachment: 141652

Committed r117028: <http://trac.webkit.org/changeset/117028>
Comment 6 WebKit Review Bot 2012-05-14 21:38:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Csaba Osztrogonác 2012-05-15 00:06:11 PDT
It broke a unittest:

Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py", line 113, in test_skipped_directories_for_symbols
    self.assertEqual(result_directories, expected_directories)
AssertionError: set(['mathml', 'compositing/webgl', 'fast/canvas/webgl', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables']) != set(['compositing/webgl', 'mathml', 'http/tests/canvas/webgl', 'mhtml', 'fast/canvas/webgl'])
Comment 8 Csaba Osztrogonác 2012-05-15 00:07:03 PDT
Reopening to attach new patch.
Comment 9 Csaba Osztrogonác 2012-05-15 00:07:09 PDT
Created attachment 141869 [details]
Patch
Comment 10 Csaba Osztrogonác 2012-05-15 00:08:30 PDT
(In reply to comment #8)
> Reopening to attach new patch.

Sorry, I didn't want to reopen the bug (because it is forbidden by ap),
webkit-patch did it automatically.
Comment 11 Hajime Morrita 2012-05-15 01:40:45 PDT
Comment on attachment 141869 [details]
Patch

Could you file another bug for this? This bug summary is apparently misleading.
Comment 12 Csaba Osztrogonác 2012-05-15 01:43:03 PDT
(In reply to comment #11)
> (From update of attachment 141869 [details])
> Could you file another bug for this? This bug summary is apparently misleading.

No, I don't have time for this burocracy ... Feel free to reuse my patch ...
Comment 13 Hajime Morrita 2012-05-15 01:47:23 PDT
Comment on attachment 141869 [details]
Patch

Considering that the changelog mentions broken revision. it's Ok to land this.
Comment 14 Csaba Osztrogonác 2012-05-15 04:57:41 PDT
Comment on attachment 141869 [details]
Patch

Clearing flags on attachment: 141869

Committed r117053: <http://trac.webkit.org/changeset/117053>
Comment 15 Csaba Osztrogonác 2012-05-15 04:57:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 16 Luke Macpherson 2012-05-15 22:25:38 PDT
(In reply to comment #15)
> All reviewed patches have been landed.  Closing bug.
Comment 17 Chris Dumez 2012-07-03 03:51:47 PDT
Comment on attachment 141652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141652&action=review

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:303
> +            "CSSVariableValue": ["fast/css/variables"],

Is this really working? I don't know if this is port-specific but on EFL port, there is no CSSVariableVariable symbol in libwebcore_efl.so after turning on the CSS_VARIABLES flag. As a consequence, the test cases get skipped even though they pass if forced.
Comment 18 Chris Dumez 2012-07-03 04:36:10 PDT
Comment on attachment 141652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141652&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:303
>> +            "CSSVariableValue": ["fast/css/variables"],
> 
> Is this really working? I don't know if this is port-specific but on EFL port, there is no CSSVariableVariable symbol in libwebcore_efl.so after turning on the CSS_VARIABLES flag. As a consequence, the test cases get skipped even though they pass if forced.

Actually, the "CSSVariableValue" symbol is present if I build in debug mode but not if I build in release.
Comment 19 Luke Macpherson 2012-07-03 17:19:02 PDT
Ok, I assume that's true for the way other tests are skipped too, but if I've got it wrong, I want to know about it.