Bug 86331 – [GStreamer] build a static list of mime-types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Philippe Normand]

[GStreamer] build a static list of mime-types

[Philippe Normand]

Created attachment 141632 [details]
Patch

[Build Bot]

Comment on attachment 141632 [details]
Patch

Attachment 141632 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12682298

[Martin Robinson]

Comment on attachment 141632 [details]
Patch

One question I have is whether all systems support the codec installer? For instance, if on Windows or some Nokia device, it's unsupported it might better to keep looking at the caps. Perhaps a USE(GSTREAMER_CODEC_INSTALLER) flag or something like that.

[Philippe Normand]

(In reply to comment #3)
> (From update of attachment 141632 [details])
> One question I have is whether all systems support the codec installer? For instance, if on Windows or some Nokia device, it's unsupported it might better to keep looking at the caps. Perhaps a USE(GSTREAMER_CODEC_INSTALLER) flag or something like that.

Well, we're not there yet and the patch doesn't change the behavior of the player, it can be seen as a refactoring I guess :)

All the typefinders are shipped in gst-plugins-base AFAIK. So if we take the example of a device not having a matroska demuxer or VP8 decoder and with the current code video/webm will still be advertized as MayBeSupported. Then if the device's OS supports the codec installer or not is a different matter I think.

[Martin Robinson]

Comment on attachment 141632 [details]
Patch

Okay. I like hope this simplifies things greatly, but we should be very cautious that this does not cause regressions that make UI clunkier.

[Martin Robinson]

Comment on attachment 141632 [details]
Patch

Also, before landing please ensure that the HTML5 score is the same before and after this patch.

[Philippe Normand]

Committed r117207: <http://trac.webkit.org/changeset/117207>