Bug 86331 - [GStreamer] build a static list of mime-types
Summary: [GStreamer] build a static list of mime-types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-13 21:21 PDT by Philippe Normand
Modified: 2012-05-15 19:54 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.34 KB, patch)
2012-05-13 21:27 PDT, Philippe Normand
mrobinson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-05-13 21:21:55 PDT
[GStreamer] build a static list of mime-types
Comment 1 Philippe Normand 2012-05-13 21:27:30 PDT
Created attachment 141632 [details]
Patch
Comment 2 Build Bot 2012-05-13 21:48:51 PDT
Comment on attachment 141632 [details]
Patch

Attachment 141632 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12682298
Comment 3 Martin Robinson 2012-05-14 08:23:07 PDT
Comment on attachment 141632 [details]
Patch

One question I have is whether all systems support the codec installer? For instance, if on Windows or some Nokia device, it's unsupported it might better to keep looking at the caps. Perhaps a USE(GSTREAMER_CODEC_INSTALLER) flag or something like that.
Comment 4 Philippe Normand 2012-05-14 09:14:56 PDT
(In reply to comment #3)
> (From update of attachment 141632 [details])
> One question I have is whether all systems support the codec installer? For instance, if on Windows or some Nokia device, it's unsupported it might better to keep looking at the caps. Perhaps a USE(GSTREAMER_CODEC_INSTALLER) flag or something like that.

Well, we're not there yet and the patch doesn't change the behavior of the player, it can be seen as a refactoring I guess :)

All the typefinders are shipped in gst-plugins-base AFAIK. So if we take the example of a device not having a matroska demuxer or VP8 decoder and with the current code video/webm will still be advertized as MayBeSupported. Then if the device's OS supports the codec installer or not is a different matter I think.
Comment 5 Martin Robinson 2012-05-15 11:53:04 PDT
Comment on attachment 141632 [details]
Patch

Okay. I like hope this simplifies things greatly, but we should be very cautious that this does not cause regressions that make UI clunkier.
Comment 6 Martin Robinson 2012-05-15 11:53:54 PDT
Comment on attachment 141632 [details]
Patch

Also, before landing please ensure that the HTML5 score is the same before and after this patch.
Comment 7 Philippe Normand 2012-05-15 19:54:42 PDT
Committed r117207: <http://trac.webkit.org/changeset/117207>