Bug 86303 - [Texmap] TextureMapperAnimations does not support keyframe with multiple animations
Summary: [Texmap] TextureMapperAnimations does not support keyframe with multiple anim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Igor Trindade Oliveira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-12 13:50 PDT by Igor Trindade Oliveira
Modified: 2012-05-13 10:00 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.35 KB, patch)
2012-05-12 13:57 PDT, Igor Trindade Oliveira
noam: review-
noam: commit-queue-
Details | Formatted Diff | Diff
Patch (6.92 KB, patch)
2012-05-12 20:54 PDT, Igor Trindade Oliveira
noam: review+
noam: commit-queue-
Details | Formatted Diff | Diff
Final patch (6.92 KB, patch)
2012-05-13 09:19 PDT, Igor Trindade Oliveira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Trindade Oliveira 2012-05-12 13:50:27 PDT
TextureMapperAnimations uses HashMap<String, TextureMapperAnimation> to store the keyframes animation info, however one keyframe can have more than one animation.
Comment 1 Igor Trindade Oliveira 2012-05-12 13:57:14 PDT
Created attachment 141584 [details]
Patch

Proposed patch.
Comment 2 Noam Rosenthal 2012-05-12 18:08:50 PDT
Comment on attachment 141584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141584&action=review

> Source/WebCore/ChangeLog:18
> +        [Texmap] TextureMapperAnimations does not support keyframe with multiple animations
> +        https://bugs.webkit.org/show_bug.cgi?id=86303
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * platform/graphics/texmap/TextureMapperAnimation.cpp:
> +        (WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
> +        (WebCore::TextureMapperAnimations::hasRunningAnimations):
> +        (WebCore::TextureMapperAnimations::add):
> +        (WebCore):
> +        (WebCore::TextureMapperAnimations::pause):
> +        (WebCore::TextureMapperAnimations::apply):
> +        * platform/graphics/texmap/TextureMapperAnimation.h:
> +        (TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >,
> +        so we can support an keyframe with multiple animations.
> +

Insufficient changelog.
Comment 3 Igor Trindade Oliveira 2012-05-12 20:54:17 PDT
Created attachment 141595 [details]
Patch

Patch V2. Changelog improved.
Comment 4 Noam Rosenthal 2012-05-12 21:19:22 PDT
Comment on attachment 141595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141595&action=review

LGTM, except for some renames

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:185
> +        const Vector<TextureMapperAnimation>& animation = it->second;

animation -> animations

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:198
> +        const Vector<TextureMapperAnimation>& animation = it->second;

ditto
Comment 5 Igor Trindade Oliveira 2012-05-13 09:19:16 PDT
Created attachment 141607 [details]
Final patch
Comment 6 WebKit Review Bot 2012-05-13 10:00:08 PDT
Comment on attachment 141607 [details]
Final patch

Clearing flags on attachment: 141607

Committed r116899: <http://trac.webkit.org/changeset/116899>
Comment 7 WebKit Review Bot 2012-05-13 10:00:13 PDT
All reviewed patches have been landed.  Closing bug.