Bug 86258 - [chromium] Prevent deadlock on CCVideoLayerImpl destruction
Summary: [chromium] Prevent deadlock on CCVideoLayerImpl destruction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-11 15:23 PDT by Adrienne Walker
Modified: 2012-05-11 19:04 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2012-05-11 15:31 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-05-11 15:23:46 PDT 
[chromium] Prevent deadlock on CCVideoLayerImpl destruction
Comment 1 Adrienne Walker 2012-05-11 15:31:22 PDT 
Created attachment 141510 [details]
Patch
Comment 2 Adrienne Walker 2012-05-11 15:33:24 PDT 
jamesr: Your suggestion to use CCLayerTreeHost::acquireLayerTextures to block the compositor thread from using a destroyed provider worked great in the case where you had another commit and much less great when the tree got destroyed and it was unclear whether a client should clear its provider pointer or not.
Comment 3 James Robinson 2012-05-11 15:36:41 PDT 
Comment on attachment 141510 [details]
Patch

R=me
Comment 4 Nat Duca 2012-05-11 15:48:47 PDT 
WIN
Comment 5 Andrew Scherkus 2012-05-11 16:26:43 PDT 
I also sense great win in this patch.
Comment 6 WebKit Review Bot 2012-05-11 19:04:03 PDT 
Comment on attachment 141510 [details]
Patch

Clearing flags on attachment: 141510

Committed r116833: <http://trac.webkit.org/changeset/116833>
Comment 7 WebKit Review Bot 2012-05-11 19:04:08 PDT 
All reviewed patches have been landed.  Closing bug.