Bug 86250 - Convert some MathML layout tests to reftests
Summary: Convert some MathML layout tests to reftests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Barton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-11 13:55 PDT by Dave Barton
Modified: 2012-05-11 17:41 PDT (History)
8 users (show)

See Also:

Attachments
Patch (36.80 KB, patch)
2012-05-11 13:57 PDT, Dave Barton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Barton 2012-05-11 13:55:13 PDT 
Convert some MathML layout tests to reftests
Comment 1 Dave Barton 2012-05-11 13:57:30 PDT 
Created attachment 141490 [details]
Patch
Comment 2 Ryosuke Niwa 2012-05-11 14:05:15 PDT 
Comment on attachment 141490 [details]
Patch

I guess we can't use xhtml extension for expected files?
Comment 3 Dave Barton 2012-05-11 14:17:21 PDT 
I didn't try making the expected files .xhtml. I'd prefer .html going forward, since it's easier to include MathML (HTML5 does the right thing by default for namespaces) and <script>s, etc. We should of course still have some old .xhtml test sources, for users who do (or did) that, but if we can generate results & new tests mostly using .html it seems easier & better. Let me know if you disagree, of course - I am still new.
Comment 4 Ryosuke Niwa 2012-05-11 14:19:36 PDT 
Nah, that's fine. In fact, it's probably preferable to fix both HTML and XHTML so that we can make sure their rendering match.
Comment 5 Ryosuke Niwa 2012-05-11 14:19:51 PDT 
s/fix/mix/
Comment 6 Eric Seidel (no email) 2012-05-11 14:20:40 PDT 
As Dave mentions, html is infinitely easier to use than xhtml.  We have bugs in our xhtml/xml handling for both SVG and MathML I'm sure.  For those, we'll need those xml tests, but otherwise we should just do html when we can. :)
Comment 7 WebKit Review Bot 2012-05-11 17:41:42 PDT 
Comment on attachment 141490 [details]
Patch

Clearing flags on attachment: 141490

Committed r116829: <http://trac.webkit.org/changeset/116829>
Comment 8 WebKit Review Bot 2012-05-11 17:41:47 PDT 
All reviewed patches have been landed.  Closing bug.