Bug 86249 - Skia does not respect a specified InterpolationQuality
: Skia does not respect a specified InterpolationQuality
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 82804
  Show dependency treegraph
 
Reported: 2012-05-11 13:48 PDT by Keyar Hood
Modified: 2012-05-15 16:52 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.30 KB, patch)
2012-05-15 08:24 PDT, Keyar Hood
no flags Details | Formatted Diff | Diff
Patch (8.04 KB, patch)
2012-05-15 11:12 PDT, Keyar Hood
no flags Details | Formatted Diff | Diff
Patch (8.62 KB, patch)
2012-05-15 13:52 PDT, Keyar Hood
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keyar Hood 2012-05-11 13:48:22 PDT
Right now the Skia code in ImageSkia.cpp does not properly respect what Interpolation Quality is set to. It should use the specified InterpolationQuality but allow demotions of quality as appropriate.
Comment 1 Keyar Hood 2012-05-15 08:24:57 PDT
Created attachment 141975 [details]
Patch
Comment 2 Stephen White 2012-05-15 11:02:19 PDT
Comment on attachment 141975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141975&action=review

> Source/WebCore/platform/graphics/GraphicsContext.cpp:488
> +        // The precompiler bit is just a hack to make the chromium code work for changes
> +        // related to (86249).

I'd remove this comment -- chromium is now doing what the FIXME above says it should do (and what the useLowQualityScale parameter implies).

> Source/WebCore/platform/graphics/GraphicsContext.cpp:585
> +        // The precompiler bit is just a hack to make the chromium code work for changes
> +        // related to (86249).

Same as above.
Comment 3 Keyar Hood 2012-05-15 11:12:29 PDT
Created attachment 142010 [details]
Patch
Comment 4 Keyar Hood 2012-05-15 13:52:15 PDT
Created attachment 142046 [details]
Patch
Comment 5 Stephen White 2012-05-15 13:55:21 PDT
Comment on attachment 142046 [details]
Patch

Looks good.  Thanks for the extra fixes.  r=me
Comment 6 WebKit Review Bot 2012-05-15 16:52:13 PDT
Comment on attachment 142046 [details]
Patch

Clearing flags on attachment: 142046

Committed r117187: <http://trac.webkit.org/changeset/117187>
Comment 7 WebKit Review Bot 2012-05-15 16:52:19 PDT
All reviewed patches have been landed.  Closing bug.