Bug 86249 - Skia does not respect a specified InterpolationQuality
: Skia does not respect a specified InterpolationQuality
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 82804
  Show dependency treegraph
 
Reported: 2012-05-11 13:48 PST by
Modified: 2012-05-15 16:52 PST (History)


Attachments
Patch (8.30 KB, patch)
2012-05-15 08:24 PST, Keyar Hood
no flags Review Patch | Details | Formatted Diff | Diff
Patch (8.04 KB, patch)
2012-05-15 11:12 PST, Keyar Hood
no flags Review Patch | Details | Formatted Diff | Diff
Patch (8.62 KB, patch)
2012-05-15 13:52 PST, Keyar Hood
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-11 13:48:22 PST
Right now the Skia code in ImageSkia.cpp does not properly respect what Interpolation Quality is set to. It should use the specified InterpolationQuality but allow demotions of quality as appropriate.
------- Comment #1 From 2012-05-15 08:24:57 PST -------
Created an attachment (id=141975) [details]
Patch
------- Comment #2 From 2012-05-15 11:02:19 PST -------
(From update of attachment 141975 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=141975&action=review

> Source/WebCore/platform/graphics/GraphicsContext.cpp:488
> +        // The precompiler bit is just a hack to make the chromium code work for changes
> +        // related to (86249).

I'd remove this comment -- chromium is now doing what the FIXME above says it should do (and what the useLowQualityScale parameter implies).

> Source/WebCore/platform/graphics/GraphicsContext.cpp:585
> +        // The precompiler bit is just a hack to make the chromium code work for changes
> +        // related to (86249).

Same as above.
------- Comment #3 From 2012-05-15 11:12:29 PST -------
Created an attachment (id=142010) [details]
Patch
------- Comment #4 From 2012-05-15 13:52:15 PST -------
Created an attachment (id=142046) [details]
Patch
------- Comment #5 From 2012-05-15 13:55:21 PST -------
(From update of attachment 142046 [details])
Looks good.  Thanks for the extra fixes.  r=me
------- Comment #6 From 2012-05-15 16:52:13 PST -------
(From update of attachment 142046 [details])
Clearing flags on attachment: 142046

Committed r117187: <http://trac.webkit.org/changeset/117187>
------- Comment #7 From 2012-05-15 16:52:19 PST -------
All reviewed patches have been landed.  Closing bug.