RESOLVED FIXED86233
Remove bbox caching from SVGPathElement 
https://bugs.webkit.org/show_bug.cgi?id=86233
Summary Remove bbox caching from SVGPathElement
Rob Buis
Reported 2012-05-11 10:56:02 PDT
I dont think this code adds much value, as SVGLocatable::getBBox is not used much out there.
Attachments
Patch (3.33 KB, patch)
2012-05-11 10:58 PDT, Rob Buis 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-05-11 10:58:04 PDT
Created attachment 141450 [details] Patch
Rob Buis
Comment 2 2012-05-11 18:29:51 PDT
I ran run-perf-tests on the svg PageLoad performance tests and there were no speed regressions there (makes sense since the changed code path is not called by these heavy svg tests). From our layout tests only svg/custom/getBBox-path.svg uses it, and there it is only asked once, so caching is not useful for this test. So overall I think the benefits outweigh the drawbacks of removing this caching, I just don't see this as a hot code path.
Nikolas Zimmermann
Comment 3 2012-05-19 08:23:53 PDT
Comment on attachment 141450 [details] Patch Good idea, this was more beneficial in the past where renderers grabbed bounds using getBBox().
Rob Buis
Comment 4 2012-05-19 13:55:24 PDT
Committed r117696: <http://trac.webkit.org/changeset/117696>
Note You need to log in before you can comment on or make changes to this bug.