Bug 86226 - Remove RenderLayer::m_scrollOverflow
Summary: Remove RenderLayer::m_scrollOverflow
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
Depends on:
Reported: 2012-05-11 10:21 PDT by Julien Chaffraix
Modified: 2012-05-11 11:47 PDT (History)
5 users (show)

See Also:

Proposed removal 1. (3.18 KB, patch)
2012-05-11 10:31 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-05-11 10:21:06 PDT
m_scrollOverflow is used in only 1 place:

IntSize scrolledContentOffset() const { return scrollOffset() + m_scrollOverflow; }

m_scrollOverflow is always set to the opposite of scrollOrigin in computeScrollDimensions() and the previous function is basically returning m_scrollOffset as RenderLayer::scrollOffset() adds scrollOrigin() to m_scrollOffset.

Let's kill this confusing variable.
Comment 1 Julien Chaffraix 2012-05-11 10:31:24 PDT
Created attachment 141440 [details]
Proposed removal 1.
Comment 2 WebKit Review Bot 2012-05-11 11:47:37 PDT
Comment on attachment 141440 [details]
Proposed removal 1.

Clearing flags on attachment: 141440

Committed r116790: <http://trac.webkit.org/changeset/116790>
Comment 3 WebKit Review Bot 2012-05-11 11:47:42 PDT
All reviewed patches have been landed.  Closing bug.