WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86226
Remove RenderLayer::m_scrollOverflow
https://bugs.webkit.org/show_bug.cgi?id=86226
Summary
Remove RenderLayer::m_scrollOverflow
Julien Chaffraix
Reported
2012-05-11 10:21:06 PDT
m_scrollOverflow is used in only 1 place: IntSize scrolledContentOffset() const { return scrollOffset() + m_scrollOverflow; } m_scrollOverflow is always set to the opposite of scrollOrigin in computeScrollDimensions() and the previous function is basically returning m_scrollOffset as RenderLayer::scrollOffset() adds scrollOrigin() to m_scrollOffset. Let's kill this confusing variable.
Attachments
Proposed removal 1.
(3.18 KB, patch)
2012-05-11 10:31 PDT
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2012-05-11 10:31:24 PDT
Created
attachment 141440
[details]
Proposed removal 1.
WebKit Review Bot
Comment 2
2012-05-11 11:47:37 PDT
Comment on
attachment 141440
[details]
Proposed removal 1. Clearing flags on attachment: 141440 Committed
r116790
: <
http://trac.webkit.org/changeset/116790
>
WebKit Review Bot
Comment 3
2012-05-11 11:47:42 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug