Bug 86218 - Two of the touch-adjustment tests are flaky
Summary: Two of the touch-adjustment tests are flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks: 85101
  Show dependency treegraph
 
Reported: 2012-05-11 08:09 PDT by Allan Sandfeld Jensen
Modified: 2012-05-14 11:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.76 KB, patch)
2012-05-11 08:12 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (4.07 KB, patch)
2012-05-14 09:44 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-05-11 08:09:52 PDT
Two of the tests was depending too much on text-size. They should be adjusted so they will give consistent results within the margin of error fonts have between platforms.
Comment 1 Allan Sandfeld Jensen 2012-05-11 08:12:48 PDT
Created attachment 141421 [details]
Patch
Comment 2 Simon Hausmann 2012-05-11 08:21:12 PDT
Comment on attachment 141421 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2012-05-11 09:32:55 PDT
Comment on attachment 141421 [details]
Patch

Clearing flags on attachment: 141421

Committed r116777: <http://trac.webkit.org/changeset/116777>
Comment 4 WebKit Review Bot 2012-05-11 09:33:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Allan Sandfeld Jensen 2012-05-14 08:02:34 PDT
Reopening since, touchadjustment/touch-inlines.html is still failing on chromium.
Comment 6 Allan Sandfeld Jensen 2012-05-14 09:44:25 PDT
Created attachment 141742 [details]
Patch

Fixup
Comment 7 Darin Adler 2012-05-14 10:15:58 PDT
Comment on attachment 141742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141742&action=review

> LayoutTests/touchadjustment/touch-inlines.html:11
> +<p style="width: 22em;">

Why use em units here instead of px?
Comment 8 WebKit Review Bot 2012-05-14 11:18:07 PDT
Comment on attachment 141742 [details]
Patch

Clearing flags on attachment: 141742

Committed r116972: <http://trac.webkit.org/changeset/116972>
Comment 9 WebKit Review Bot 2012-05-14 11:18:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Allan Sandfeld Jensen 2012-05-14 11:33:03 PDT
(In reply to comment #7)
> (From update of attachment 141742 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141742&action=review
> 
> > LayoutTests/touchadjustment/touch-inlines.html:11
> > +<p style="width: 22em;">
> 
> Why use em units here instead of px?

Well, for Ahem it makes it easy to count where the line-break should be since they are square and monotype. The original test was just a partial copy of the text transformation-test in ManualTests/qt.