Bug 86211 - Web Inspector: add Profiler.getHeapObjectId command
Summary: Web Inspector: add Profiler.getHeapObjectId command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 86204
  Show dependency tree / graph
 
Reported: 2012-05-11 06:46 PDT by Yury Semikhatsky
Modified: 2012-05-11 08:05 PDT (History)
14 users (show)

See Also:

Attachments
Patch (10.00 KB, patch)
2012-05-11 06:48 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-11 06:46:27 PDT 
We need this command to implement "reveal in heap snapshot" action.
Comment 1 Yury Semikhatsky 2012-05-11 06:48:34 PDT 
Created attachment 141405 [details]
Patch
Comment 2 Pavel Feldman 2012-05-11 07:14:48 PDT 
Comment on attachment 141405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141405&action=review

> Source/WebCore/inspector/Inspector.json:2680
> +                    { "name": "heapSnapshotObjectId", "type": "string", "description": "Heap snapshot object id." }

Please introduce type for the id.

> Source/WebCore/inspector/InspectorProfilerAgent.cpp:455
> +    ScriptValue jsValue = injectedScript.findObjectById(objectId);

jsValue -> value.
Comment 3 Yury Semikhatsky 2012-05-11 07:47:41 PDT 
(In reply to comment #2)
> (From update of attachment 141405 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141405&action=review
> 
> > Source/WebCore/inspector/Inspector.json:2680
> > +                    { "name": "heapSnapshotObjectId", "type": "string", "description": "Heap snapshot object id." }
> 
> Please introduce type for the id.
Done.

> 
> > Source/WebCore/inspector/InspectorProfilerAgent.cpp:455
> > +    ScriptValue jsValue = injectedScript.findObjectById(objectId);
> 
> jsValue -> value.
Done.
Comment 4 Yury Semikhatsky 2012-05-11 08:05:00 PDT 
Committed r116768: <http://trac.webkit.org/changeset/116768>