RESOLVED FIXED 86211
Web Inspector: add Profiler.getHeapObjectId command 
https://bugs.webkit.org/show_bug.cgi?id=86211
Summary Web Inspector: add Profiler.getHeapObjectId command
Yury Semikhatsky
Reported 2012-05-11 06:46:27 PDT
We need this command to implement "reveal in heap snapshot" action.
Attachments
Patch (10.00 KB, patch)
2012-05-11 06:48 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-05-11 06:48:34 PDT
Created attachment 141405 [details] Patch
Pavel Feldman
Comment 2 2012-05-11 07:14:48 PDT
Comment on attachment 141405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141405&action=review > Source/WebCore/inspector/Inspector.json:2680 > + { "name": "heapSnapshotObjectId", "type": "string", "description": "Heap snapshot object id." } Please introduce type for the id. > Source/WebCore/inspector/InspectorProfilerAgent.cpp:455 > + ScriptValue jsValue = injectedScript.findObjectById(objectId); jsValue -> value.
Yury Semikhatsky
Comment 3 2012-05-11 07:47:41 PDT
(In reply to comment #2) > (From update of attachment 141405 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141405&action=review > > > Source/WebCore/inspector/Inspector.json:2680 > > + { "name": "heapSnapshotObjectId", "type": "string", "description": "Heap snapshot object id." } > > Please introduce type for the id. Done. > > > Source/WebCore/inspector/InspectorProfilerAgent.cpp:455 > > + ScriptValue jsValue = injectedScript.findObjectById(objectId); > > jsValue -> value. Done.
Yury Semikhatsky
Comment 4 2012-05-11 08:05:00 PDT
Committed r116768: <http://trac.webkit.org/changeset/116768>
Note You need to log in before you can comment on or make changes to this bug.