Bug 86188 - Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
Summary: Web Inspector: use div, not span as a parent element for ElementsTreeOutline ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-11 02:01 PDT by Andrey Kosyakov
Modified: 2012-05-11 02:35 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.06 KB, patch)
2012-05-11 02:04 PDT, Andrey Kosyakov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-05-11 02:01:39 PDT
This is a follow-up fix for r116739. The audit panel uses span as a container for formatted results, including those produced by node formatter. ElementsTreeOutline needs offsetWidth in treeElementFromEvent(), which is only meaningful for block-level elements (returns 0 for inline).
Comment 1 Andrey Kosyakov 2012-05-11 02:04:23 PDT
Created attachment 141358 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-11 02:14:36 PDT
Comment on attachment 141358 [details]
Patch

We should consider making ElementsTreeOutline element a div.
Comment 3 Andrey Kosyakov 2012-05-11 02:35:13 PDT
Committed r116743: <http://trac.webkit.org/changeset/116743>