Bug 86163 - Simplify FloatingObject by removing unnecessary convenience methods.
: Simplify FloatingObject by removing unnecessary convenience methods.
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-05-10 17:14 PST by
Modified: 2012-05-11 11:20 PST (History)


Attachments
Patch (7.22 KB, patch)
2012-05-10 17:19 PST, Emil A Eklund
no flags Review Patch | Details | Formatted Diff | Diff
Patch for landing (7.25 KB, patch)
2012-05-10 17:41 PST, Emil A Eklund
no flags Review Patch | Details | Formatted Diff | Diff
Patch for landing (7.86 KB, patch)
2012-05-10 17:52 PST, Emil A Eklund
no flags Review Patch | Details | Formatted Diff | Diff
Patch for landing (8.45 KB, patch)
2012-05-11 10:31 PST, Emil A Eklund
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-10 17:14:44 PST
Simplify the pixel snapping in FloatingObject by getting rid of a bunch of convenience functions.
------- Comment #1 From 2012-05-10 17:19:25 PST -------
Created an attachment (id=141297) [details]
Patch
------- Comment #2 From 2012-05-10 17:36:17 PST -------
(From update of attachment 141297 [details])
Yes, yes yes!
------- Comment #3 From 2012-05-10 17:36:56 PST -------
(From update of attachment 141297 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=141297&action=review

> Source/WebCore/ChangeLog:3
> +        Simplify FloatingObject API

I am not sure that API means what you think it means ;-)
------- Comment #4 From 2012-05-10 17:39:09 PST -------
> I am not sure that API means what you think it means ;-)

Yeah, I agree, not the worded description. I'll update it before committing.
------- Comment #5 From 2012-05-10 17:41:07 PST -------
(From update of attachment 141297 [details])
Attachment 141297 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12676034
------- Comment #6 From 2012-05-10 17:41:36 PST -------
Created an attachment (id=141299) [details]
Patch for landing
------- Comment #7 From 2012-05-10 17:52:05 PST -------
Created an attachment (id=141302) [details]
Patch for landing
------- Comment #8 From 2012-05-10 21:57:00 PST -------
(From update of attachment 141302 [details])
Rejecting attachment 141302 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
:FloatingObject*>::string(const WebCore::RenderBlock::FloatingObject*)':
Source/WebCore/rendering/RenderBlock.cpp:7342: error: 'const struct WebCore::RenderBlock::FloatingObject' has no member named 'pixelSnappedY'
Source/WebCore/rendering/RenderBlock.cpp:7342: error: 'const struct WebCore::RenderBlock::FloatingObject' has no member named 'pixelSnappedMaxX'
make: *** [out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/RenderBlock.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/12663565
------- Comment #9 From 2012-05-11 10:31:50 PST -------
Created an attachment (id=141441) [details]
Patch for landing
------- Comment #10 From 2012-05-11 11:20:54 PST -------
(From update of attachment 141441 [details])
Clearing flags on attachment: 141441

Committed r116788: <http://trac.webkit.org/changeset/116788>
------- Comment #11 From 2012-05-11 11:20:59 PST -------
All reviewed patches have been landed.  Closing bug.