Bug 86163 - Simplify FloatingObject by removing unnecessary convenience methods.
: Simplify FloatingObject by removing unnecessary convenience methods.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Emil A Eklund
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-10 17:14 PDT by Emil A Eklund
Modified: 2012-05-11 11:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.22 KB, patch)
2012-05-10 17:19 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (7.25 KB, patch)
2012-05-10 17:41 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (7.86 KB, patch)
2012-05-10 17:52 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (8.45 KB, patch)
2012-05-11 10:31 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-05-10 17:14:44 PDT
Simplify the pixel snapping in FloatingObject by getting rid of a bunch of convenience functions.
Comment 1 Emil A Eklund 2012-05-10 17:19:25 PDT
Created attachment 141297 [details]
Patch
Comment 2 Eric Seidel 2012-05-10 17:36:17 PDT
Comment on attachment 141297 [details]
Patch

Yes, yes yes!
Comment 3 Darin Adler 2012-05-10 17:36:56 PDT
Comment on attachment 141297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141297&action=review

> Source/WebCore/ChangeLog:3
> +        Simplify FloatingObject API

I am not sure that API means what you think it means ;-)
Comment 4 Emil A Eklund 2012-05-10 17:39:09 PDT
> I am not sure that API means what you think it means ;-)

Yeah, I agree, not the worded description. I'll update it before committing.
Comment 5 Build Bot 2012-05-10 17:41:07 PDT
Comment on attachment 141297 [details]
Patch

Attachment 141297 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12676034
Comment 6 Emil A Eklund 2012-05-10 17:41:36 PDT
Created attachment 141299 [details]
Patch for landing
Comment 7 Emil A Eklund 2012-05-10 17:52:05 PDT
Created attachment 141302 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-05-10 21:57:00 PDT
Comment on attachment 141302 [details]
Patch for landing

Rejecting attachment 141302 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
:FloatingObject*>::string(const WebCore::RenderBlock::FloatingObject*)':
Source/WebCore/rendering/RenderBlock.cpp:7342: error: 'const struct WebCore::RenderBlock::FloatingObject' has no member named 'pixelSnappedY'
Source/WebCore/rendering/RenderBlock.cpp:7342: error: 'const struct WebCore::RenderBlock::FloatingObject' has no member named 'pixelSnappedMaxX'
make: *** [out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/RenderBlock.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/12663565
Comment 9 Emil A Eklund 2012-05-11 10:31:50 PDT
Created attachment 141441 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-05-11 11:20:54 PDT
Comment on attachment 141441 [details]
Patch for landing

Clearing flags on attachment: 141441

Committed r116788: <http://trac.webkit.org/changeset/116788>
Comment 11 WebKit Review Bot 2012-05-11 11:20:59 PDT
All reviewed patches have been landed.  Closing bug.