Bug 86151 – Reduce GradientAttributes object size

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Rob Buis]

This can use better bitpacking.

[Rob Buis]

Created attachment 141283 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 141283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review

> Source/WebCore/svg/GradientAttributes.h:80
> +    unsigned m_spreadMethod : 2;
> +    unsigned m_gradientUnits : 2;

Do we need to add any COMPILE_ASSERTS that these fit in two bits?  Will the compiler warn us as-is?

[Ryosuke Niwa]

Comment on attachment 141283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review

> Source/WebCore/svg/GradientAttributes.h:84
>      bool m_spreadMethodSet : 1;
>      bool m_gradientUnitsSet : 1;

We can make these member variables to unsigned and save more space on Windows.

[Ryosuke Niwa]

Comment on attachment 141283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review

> Source/WebCore/svg/GradientAttributes.h:84
>      bool m_spreadMethodSet : 1;
>      bool m_gradientUnitsSet : 1;

We can make these member variables to unsigned and save more space on Windows.

[Ryosuke Niwa]

Has this been landed yet?

[Rob Buis]

(In reply to comment #5)
> Has this been landed yet?

No, I plan to make some changes and will maybe post again for the final patch.

[Rob Buis]

Created attachment 159593 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159593 [details]
Patch

Clearing flags on attachment: 159593

Committed r126134: <http://trac.webkit.org/changeset/126134>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.