Bug 86149 – libjpeg_turbo doesn't properly set the alpha value to 0xFF on Android

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Adam Barth]

libjpeg_turbo doesn't properly set the alpha value to 0xFF on Android

[Adam Barth]

Created attachment 141275 [details]
Patch

[Adam Barth]

I'm not entirely sure what to do with this patch.  Noel: Any thoughts?

[Min Qin]

Hironori has a patch that fixed this in libjpeg_turbo:
http://libjpeg-turbo.svn.sourceforge.net/viewvc/libjpeg-turbo?view=revision&revision=810
But the change has't been merged into chromium yet.

So I am wondering whether we should wait for that to happen or we can submit this change first and wait for that change to merge.

[Adam Barth]

> Hironori has a patch that fixed this in libjpeg_turbo:
> http://libjpeg-turbo.svn.sourceforge.net/viewvc/libjpeg-turbo?view=revision&revision=810
> But the change has't been merged into chromium yet.

Fri Mar 16 14:30:46 2012 UTC (7 weeks, 6 days ago)

What's the ETA for merging that into Chromium?

> So I am wondering whether we should wait for that to happen or we can submit this change first and wait for that change to merge.

One possibility is to submit this change with a link to the fix so that folks will know when to remove it in the future.

[Min Qin]

(In reply to comment #4)
> > Hironori has a patch that fixed this in libjpeg_turbo:
> > http://libjpeg-turbo.svn.sourceforge.net/viewvc/libjpeg-turbo?view=revision&revision=810
> > But the change has't been merged into chromium yet.
> 
> Fri Mar 16 14:30:46 2012 UTC (7 weeks, 6 days ago)
> 
> What's the ETA for merging that into Chromium?

Hironori san, any idea when this change will be merged into chromium?

> 
> > So I am wondering whether we should wait for that to happen or we can submit this change first and wait for that change to merge.
> 
> One possibility is to submit this change with a link to the fix so that folks will know when to remove it in the future.

That should also work, let's see how long will that fix go into chromium first.

[Hironori Bono]

Greetings Min,

Thanks for your update. I will update our copy of libjpeg-turbo to the latest trunk next week.

Regards,

Hironori Bono

(In reply to comment #5)
> Hironori san, any idea when this change will be merged into chromium?

[Adam Barth]

Comment on attachment 141275 [details]
Patch

Thanks!  I'm going to leave this bug open for a bit to remind me to follow up.

[noel gordon]

Sounds good, want hbono's fix for libjpeg-turbo in the chromium tree, http://crbug.com/106020

[noel gordon]

Right, new libjpeg-turbo r829 is now in webkit and should obviate the need for this change.

@qinmin could you build and test Android with webkit TOT libjpeg-turbo r829, and let us know here if it works without all the #if OS(ANDROID) in the current patch?

[noel gordon]

The webkit revision to test should be http://trac.webkit.org/changeset/117020 (r117020) or above.

[Min Qin]

Will do that tomorrow

[Min Qin]

Yes, with libjpeg-turbo r829, the images now render correctly without this patch.

I will remove the code from downstream android implementation after our next merge.

[Adam Barth]

Thanks Min!