Bug 86143 - WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
Summary: WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on: 86378
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-10 14:09 PDT by Andreas Kling
Modified: 2012-05-14 09:14 PDT (History)
4 users (show)

See Also:

Attachments
Modest first stab (31.56 KB, patch)
2012-05-10 14:19 PDT, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch again (31.70 KB, patch)
2012-05-10 15:06 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (29.21 KB, patch)
2012-05-11 11:10 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (31.75 KB, patch)
2012-05-11 11:12 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (32.12 KB, patch)
2012-05-11 12:41 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-05-10 14:09:35 PDT 
<rdar://problem/10777218>
Comment 1 Andreas Kling 2012-05-10 14:19:32 PDT 
Created attachment 141254 [details]
Modest first stab
Comment 2 WebKit Review Bot 2012-05-10 14:27:30 PDT 
Attachment 141254 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/WebContext.h:250:  The parameter name "connection" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/WebContext.h:250:  The parameter name "messageID" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-05-10 14:58:25 PDT 
Comment on attachment 141254 [details]
Modest first stab

Attachment 141254 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12673051
Comment 4 Early Warning System Bot 2012-05-10 15:02:38 PDT 
Comment on attachment 141254 [details]
Modest first stab

Attachment 141254 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12670113
Comment 5 Andreas Kling 2012-05-10 15:06:12 PDT 
Created attachment 141274 [details]
Patch again

Apparently everyone doesn't build on OS X. Crazy.
Comment 6 Andreas Kling 2012-05-11 11:10:39 PDT 
Created attachment 141453 [details]
Patch

Rebased because Anders.
Comment 7 Andreas Kling 2012-05-11 11:12:30 PDT 
Created attachment 141454 [details]
Patch
Comment 8 Andreas Kling 2012-05-11 12:41:25 PDT 
Created attachment 141476 [details]
Patch

Per AndersCa's request match WebContext's addQueueClient with a removeQueueClient in the destructor.
Comment 9 Andreas Kling 2012-05-11 12:49:06 PDT 
Comment on attachment 141476 [details]
Patch

Clearing flags on attachment: 141476

Committed r116796: <http://trac.webkit.org/changeset/116796>
Comment 10 Andreas Kling 2012-05-11 12:49:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Antti Koivisto 2012-05-14 09:14:25 PDT 
Looks like this caused an API test failure, bug 86378.