Our application uses an editable WebKitGTK instance with the spell checking feature enabled. Unfortunately, the spell checker doesn't recognize contractions properly. For example, if you type "I've" you will get the "ve" marked as misspelled. This bug doesn't seem to appear in Safari or Apple Mail, so I'd assume this is related specifically to WebKitGTK.
Created attachment 141548 [details] Patch
Comment on attachment 141548 [details] Patch Clearing flags on attachment: 141548 Committed r117628: <http://trac.webkit.org/changeset/117628>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by 86936
Sorry I had to roll this one out, it caused timeouts in the editing test suite.
(In reply to comment #5) > Sorry I had to roll this one out, it caused timeouts in the editing test suite. Thanks for rolling this out. I'll post a revised patch soon.
Created attachment 143171 [details] Patch
I've uploaded a new version of the patch that (I hope) fixes the failures. It seems that the documentation for g_utf8_find_next_char wasn't clear about what return values indicate terminating situations. It's necessary to check both word == 0 and *word == 0. I have also improved the code in SpellCheckerEnchant to deal with more than one word at a time. I realized that WebKit will sometimes send more than one word after further testing. This passes tests locally for me.
Comment on attachment 143171 [details] Patch Clearing flags on attachment: 143171 Committed r119113: <http://trac.webkit.org/changeset/119113>
Re-opened since this is blocked by 88016
I believe that I was wrong to attempt to try to move away from Pango for word splitting here. Word splitting depends a great deal on language and Pango encapsulates all those smarts. It turns out that this bug is actually https://bugzilla.gnome.org/show_bug.cgi?id=97545. It seems reasonable that we can just duplicate the work-around that gtkspell uses, which is to special case apostrophes followed by alphabetic characters.
Created attachment 149770 [details] Patch
Comment on attachment 149770 [details] Patch Third time is the charm?
Comment on attachment 149770 [details] Patch Clearing flags on attachment: 149770 Committed r121360: <http://trac.webkit.org/changeset/121360>