RESOLVED FIXED 86107
don't use autoinstall to import pywebsocket but check it in WebKit directly 
https://bugs.webkit.org/show_bug.cgi?id=86107
Summary don't use autoinstall to import pywebsocket but check it in WebKit directly
Takashi Toyoshima
Reported 2012-05-10 09:46:02 PDT
Currently, we use webkitpy's autoinstall mechanism. But it causes wasteful network traffic by many bots and also is weak at hosting server's flakiness. Fortunately, the license of pywebsocket is compatible to one of WebKit. It must be better to check it into WebKit directory than using autoinstall.
Attachments
Patch (552.56 KB, patch)
2012-05-10 09:53 PDT, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Patch (229.11 KB, patch)
2012-05-10 10:02 PDT, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2012-05-10 09:53:13 PDT
Created attachment 141186 [details] Patch
Takashi Toyoshima
Comment 2 2012-05-10 10:02:07 PDT
Created attachment 141187 [details] Patch
Takashi Toyoshima
Comment 3 2012-05-10 10:17:30 PDT
Hi Adam, as we discussed, I made a change to import pywebsocket directly. I have two plans now. My first patch does - copy pywebsocket-0.7.4/src to thirdparty/pywebsocket - make empty __init__.py in thirdparty/pywebsocket for python to import it correctly Second one does - copy pywebsocket-0.7.4/src/mod_pywebsocket to thirdparty/mod_pywebsocket - copy pywebsocket-0.7.4/src/COPYING to thirdparty/mod_pywebsocket/COPYING The first plan is more compatible to autoinstall because it copyed in the same way to thirdparty/auoinstall/pywebsocket with empty __init__.py. The second plan doesn't need additional empty __init__.py and also omit to import misc files containing test and example directories. I feel the second one is better because misc files were not used. Other common changes are - remove pywebsocket related codes from thirdparty/__init__.py and thirdparty/__init___unittest.py - change pywebsocket import path in layout_tests/servers/websocket_server.py
Adam Barth
Comment 4 2012-05-10 10:58:08 PDT
Comment on attachment 141187 [details] Patch Thanks.
Adam Barth
Comment 5 2012-05-10 11:03:34 PDT
> The second plan doesn't need additional empty __init__.py and also omit to import misc files containing test and example directories. I feel the second one is better because misc files were not used. Agreed.
WebKit Review Bot
Comment 6 2012-05-10 11:37:51 PDT
Comment on attachment 141187 [details] Patch Clearing flags on attachment: 141187 Committed r116668: <http://trac.webkit.org/changeset/116668>
WebKit Review Bot
Comment 7 2012-05-10 11:37:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.