WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
86106
Change isBlock and isInline functions to check for isElementNode
https://bugs.webkit.org/show_bug.cgi?id=86106
Summary
Change isBlock and isInline functions to check for isElementNode
Abhishek Arya
Reported
2012-05-10 09:39:09 PDT
This came up in discussion on bug
https://bugs.webkit.org/show_bug.cgi?id=84995
. We may to want to change the isElementNode check in enclosingBlock in htmlediting.cpp and instead do it on isBlock and isInline functions.
Attachments
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-05-10 09:42:09 PDT
Makes sense.
Ahmad Saleem
Comment 2
2023-01-17 18:40:59 PST
Fixed here -
https://chromium.googlesource.com/chromium/blink/+/6415003fe8070545c67d82f88c69512bd38b2f9f
Ahmad Saleem
Comment 3
2023-01-24 04:42:44 PST
PR -
https://github.com/WebKit/WebKit/pull/9034
Ahmad Saleem
Comment 4
2023-01-24 12:12:44 PST
Based on discussion on PR, this change is not required anymore and it does not fix any bug or crash or anything, it might be good change in the past but not anymore. Closing this as "RESOLVED WONTFIX". Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug