Bug 86103 - Some Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in LocalFileSystem.cpp
Summary: Some Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in L...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kinuko Yasuda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 09:18 PDT by Chris H-C
Modified: 2012-05-17 22:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.63 KB, patch)
2012-05-15 07:20 PDT, Kinuko Yasuda 		rwlbuis: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris H-C 2012-05-10 09:18:49 PDT 
As per Bug#84135, there are some compilation errors in LocalFileSystem.cpp (FileSystemSynchronousMode doesn't exist, for instance). This bug shall track their resolution.
Comment 1 Kinuko Yasuda 2012-05-15 07:20:28 PDT 
Created attachment 141962 [details]
Patch
Comment 2 Kinuko Yasuda 2012-05-15 07:21:19 PDT 
I think this should fix build errors with ENABLE(FILE_SYSTEM) on non-chromium ports (though I couldn't test on all platforms).
Comment 3 Chris H-C 2012-05-15 07:26:39 PDT 
(In reply to comment #2)
> I think this should fix build errors with ENABLE(FILE_SYSTEM) on non-chromium ports (though I couldn't test on all platforms).

Sorry about that. We're looking to get a BlackBerry buildbot up and running ASAP to make this less painful all around.

Patch lgtm, but that's all I can do :S Adding some people from our port.
Comment 4 Rob Buis 2012-05-17 07:27:45 PDT 
Comment on attachment 141962 [details]
Patch

Looks good, thanks for the BB fix too!
Comment 5 Kinuko Yasuda 2012-05-17 22:43:27 PDT 
Committed r117544: <http://trac.webkit.org/changeset/117544>