Bug 86097 - Web Inspector: load heap snapshot implementation.
Summary: Web Inspector: load heap snapshot implementation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 07:20 PDT by Ilya Tikhonovsky
Modified: 2012-05-11 06:52 PDT (History)
10 users (show)

See Also:

Attachments
Patch (17.51 KB, patch)
2012-05-10 07:38 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (18.77 KB, patch)
2012-05-11 04:59 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-10 07:20:25 PDT 
%subj%
Comment 1 Ilya Tikhonovsky 2012-05-10 07:38:15 PDT 
Created attachment 141168 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-11 02:52:56 PDT 
Comment on attachment 141168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141168&action=review

> Source/WebCore/ChangeLog:7
> +

Please provide a brief description of the change.

> Source/WebCore/inspector/front-end/CSSSelectorProfileView.js:361
> +        if (title === undefined)

if (!title) ?

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:693
> +            if (profile.uid < 0)

Let's make the profile data source explicit and skip here profiles which have been loaded from file.

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:845
> +            this.sidebarElement.subtitle = WebInspector.UIString("Saving\u2026 %d\%", Math.floor(this._savedChunksCount * 10000 / this._totalNumberOfChunks) / 100);

Can we use Number.toFixed(2) instead to get desired formatting?

> Source/WebCore/inspector/front-end/ProfilesPanel.js:248
> +        if (!file.name.endsWith(".whs")) {

probably just .heapsnapshot?
Comment 3 Ilya Tikhonovsky 2012-05-11 04:59:36 PDT 
Created attachment 141380 [details]
Patch
Comment 4 Ilya Tikhonovsky 2012-05-11 05:00:27 PDT 
(In reply to comment #2)
> (From update of attachment 141168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141168&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please provide a brief description of the change.

done

> 
> > Source/WebCore/inspector/front-end/CSSSelectorProfileView.js:361
> > +        if (title === undefined)
> 
> if (!title) ?

done

> 
> > Source/WebCore/inspector/front-end/HeapSnapshotView.js:693
> > +            if (profile.uid < 0)

done

> 
> Let's make the profile data source explicit and skip here profiles which have been loaded from file.
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotView.js:845
> > +            this.sidebarElement.subtitle = WebInspector.UIString("Saving\u2026 %d\%", Math.floor(this._savedChunksCount * 10000 / this._totalNumberOfChunks) / 100);
> 
> Can we use Number.toFixed(2) instead to get desired formatting?

done

> 
> > Source/WebCore/inspector/front-end/ProfilesPanel.js:248
> > +        if (!file.name.endsWith(".whs")) {
> 
> probably just .heapsnapshot?

done
Comment 5 Yury Semikhatsky 2012-05-11 06:12:07 PDT 
Comment on attachment 141380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141380&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:691
> +        if (this.profile._fromFile)

Can you make _fromFile public and put it on the base profile header?
Comment 6 Ilya Tikhonovsky 2012-05-11 06:52:47 PDT 
Committed r116764: <http://trac.webkit.org/changeset/116764>