Bug 86097 – Web Inspector: load heap snapshot implementation.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

%subj%

[Ilya Tikhonovsky]

Created attachment 141168 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 141168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141168&action=review

> Source/WebCore/ChangeLog:7
> +

Please provide a brief description of the change.

> Source/WebCore/inspector/front-end/CSSSelectorProfileView.js:361
> +        if (title === undefined)

if (!title) ?

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:693
> +            if (profile.uid < 0)

Let's make the profile data source explicit and skip here profiles which have been loaded from file.

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:845
> +            this.sidebarElement.subtitle = WebInspector.UIString("Saving\u2026 %d\%", Math.floor(this._savedChunksCount * 10000 / this._totalNumberOfChunks) / 100);

Can we use Number.toFixed(2) instead to get desired formatting?

> Source/WebCore/inspector/front-end/ProfilesPanel.js:248
> +        if (!file.name.endsWith(".whs")) {

probably just .heapsnapshot?

[Ilya Tikhonovsky]

Created attachment 141380 [details]
Patch

[Ilya Tikhonovsky]

(In reply to comment #2)
> (From update of attachment 141168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141168&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please provide a brief description of the change.

done

> 
> > Source/WebCore/inspector/front-end/CSSSelectorProfileView.js:361
> > +        if (title === undefined)
> 
> if (!title) ?

done

> 
> > Source/WebCore/inspector/front-end/HeapSnapshotView.js:693
> > +            if (profile.uid < 0)

done

> 
> Let's make the profile data source explicit and skip here profiles which have been loaded from file.
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotView.js:845
> > +            this.sidebarElement.subtitle = WebInspector.UIString("Saving\u2026 %d\%", Math.floor(this._savedChunksCount * 10000 / this._totalNumberOfChunks) / 100);
> 
> Can we use Number.toFixed(2) instead to get desired formatting?

done

> 
> > Source/WebCore/inspector/front-end/ProfilesPanel.js:248
> > +        if (!file.name.endsWith(".whs")) {
> 
> probably just .heapsnapshot?

done

[Yury Semikhatsky]

Comment on attachment 141380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141380&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:691
> +        if (this.profile._fromFile)

Can you make _fromFile public and put it on the base profile header?

[Ilya Tikhonovsky]

Committed r116764: <http://trac.webkit.org/changeset/116764>