Bug 86096 - [BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame->view() are invalid
Summary: [BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 06:55 PDT by Antonio Gomes
Modified: 2012-05-10 10:15 PDT (History)
1 user (show)

See Also:


Attachments
(committed r116657, r=rbuis) Patch (5.98 KB, patch)
2012-05-10 07:09 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-05-10 06:55:00 PDT
George Staikos 2012-05-06 23:04:05 EDT

This is an interesting bug.  


IntPoint BackingStoreClient::scrollPosition() const
{    ASSERT(m_frame);
    return m_frame->view()->scrollPosition() -
pointToSize(m_frame->view()->mini
mumScrollPosition());
}


m_frame->view() is null.  m_frame is in the middle of construction and is
trying to create its view but malloc is blocked on a mutex.  Meanwhile the test
driver, which runs in the Plaid Zone in terms of speed, is already pinch
zooming the page.

Realistically no user can ever hit this. 

In actuality, the assertions in backingstoreclient are wrong and need to be
fixed.  at a minimum, m_frame->view() can be null or invalid, and perhaps
m_frame can be too.

Adam / Antonio please fix in all branches.
Comment 1 Antonio Gomes 2012-05-10 07:09:20 PDT
Created attachment 141163 [details]
(committed r116657, r=rbuis) Patch
Comment 2 Rob Buis 2012-05-10 07:15:58 PDT
Comment on attachment 141163 [details]
(committed r116657, r=rbuis) Patch

LGTM.
Comment 3 Antonio Gomes 2012-05-10 10:15:38 PDT
Comment on attachment 141163 [details]
(committed r116657, r=rbuis) Patch

Committed r116657.