Bug 86089 - [Qt] Rename QDeclarative* to QQml*
Summary: [Qt] Rename QDeclarative* to QQml*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Hansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 05:27 PDT by Kent Hansen
Modified: 2012-05-10 08:11 PDT (History)
4 users (show)

See Also:


Attachments
Patch (27.09 KB, patch)
2012-05-10 05:29 PDT, Kent Hansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Hansen 2012-05-10 05:27:13 PDT
[Qt] Rename QDeclarative* to QQml*
Comment 1 Kent Hansen 2012-05-10 05:29:05 PDT
Created attachment 141153 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-10 05:33:02 PDT
Attachment 141153 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1336:  QQuickWebViewExperimental::schemeDelegates_At is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1344:  QQuickWebViewExperimental::schemeDelegates_Append is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1356:  QQuickWebViewExperimental::schemeDelegates_Count is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1361:  QQuickWebViewExperimental::schemeDelegates_Clear is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:309:  schemeDelegates_At is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:310:  schemeDelegates_Append is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:311:  schemeDelegates_Count is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:312:  schemeDelegates_Clear is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 8 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Hausmann 2012-05-10 05:34:17 PDT
Comment on attachment 141153 [details]
Patch

r=me, but let's wait for the EWS to give green lights before landing this.
Comment 4 WebKit Review Bot 2012-05-10 08:11:54 PDT
Comment on attachment 141153 [details]
Patch

Clearing flags on attachment: 141153

Committed r116646: <http://trac.webkit.org/changeset/116646>
Comment 5 WebKit Review Bot 2012-05-10 08:11:59 PDT
All reviewed patches have been landed.  Closing bug.