Bug 86064 – [Shadow DOM][Refactoring] HTMLContentSelector family should have better name

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

The name was invented before Shadow DOM spec was formally written.
There is now a concept named "distribution". So that implementation should follow such terminology.

[Hajime Morrita]

Created attachment 141329 [details]
WIP

[Hajime Morrita]

Created attachment 141338 [details]
WIP

[Build Bot]

Comment on attachment 141338 [details]
WIP

Attachment 141338 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12666417

[Early Warning System Bot]

Comment on attachment 141338 [details]
WIP

Attachment 141338 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12663603

[Gyuyoung Kim]

Comment on attachment 141338 [details]
WIP

Attachment 141338 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12675125

[Early Warning System Bot]

Comment on attachment 141338 [details]
WIP

Attachment 141338 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12659011

[Gustavo Noronha (kov)]

Comment on attachment 141338 [details]
WIP

Attachment 141338 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12670225

[Hajime Morrita]

Created attachment 141348 [details]
WIP

[Gustavo Noronha (kov)]

Comment on attachment 141348 [details]
WIP

Attachment 141348 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12671318

[Dimitri Glazkov (Google)]

Comment on attachment 141348 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=141348&action=review

Some name bikeshedding.

> Source/WebCore/dom/ElementShadow.cpp:43
> +    : m_needsRecalcDistribution(false)

needsRedistributing

> Source/WebCore/html/shadow/ShadowDistributor.h:46
> +class ShadowBoundaryDistribution {

ContentDistribution

> Source/WebCore/html/shadow/ShadowDistributor.h:68
> +        RefPtr<Item> m_next;
> +        RefPtr<Item> m_previous;

Shouldn't be RefPtrs, right?

> Source/WebCore/html/shadow/ShadowDistributor.h:88
> +    RefPtr<Item> m_first;
> +    RefPtr<Item> m_last;

Ditto about RefPtrs.

> Source/WebCore/html/shadow/ShadowDistributor.h:91
> +class ShadowDistributor {

ContentDistributor

[Hajime Morrita]

Created attachment 141622 [details]
WIP

[Hajime Morrita]

Created attachment 141623 [details]
Patch

[Hajime Morrita]

Hi Dimitri, thanks for taking a look!
I updated the patch.

(In reply to comment #10)
> (From update of attachment 141348 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141348&action=review
> 
> Some name bikeshedding.
> 
> > Source/WebCore/dom/ElementShadow.cpp:43
> > +    : m_needsRecalcDistribution(false)
> 
> needsRedistributing
Done.

> 
> > Source/WebCore/html/shadow/ShadowDistributor.h:46
> > +class ShadowBoundaryDistribution {
> 
> ContentDistribution
Done.

> 
> > Source/WebCore/html/shadow/ShadowDistributor.h:68
> > +        RefPtr<Item> m_next;
> > +        RefPtr<Item> m_previous;
> 
> Shouldn't be RefPtrs, right?
Should be. But I'd like to do it in a separate patch to
isolate possible revealing of hidden bugs... 
Actually, I'm thinking to kill this Item class in following patch(-es).

> 
> > Source/WebCore/html/shadow/ShadowDistributor.h:88
> > +    RefPtr<Item> m_first;
> > +    RefPtr<Item> m_last;
> 
> Ditto about RefPtrs.
> 
> > Source/WebCore/html/shadow/ShadowDistributor.h:91
> > +class ShadowDistributor {
> 
> ContentDistributor
Done.

[Dimitri Glazkov (Google)]

(In reply to comment #13)

> > Shouldn't be RefPtrs, right?
> Should be. But I'd like to do it in a separate patch to
> isolate possible revealing of hidden bugs... 
> Actually, I'm thinking to kill this Item class in following patch(-es).

Sounds good. We usually add FIXMEs referencing bugs for future work.

[Dimitri Glazkov (Google)]

Comment on attachment 141623 [details]
Patch

not sure why gtk is angry at you.

[Hajime Morrita]

Thanks for r+ing!

(In reply to comment #14)
> (In reply to comment #13)
> 
> > > Shouldn't be RefPtrs, right?
> > Should be. But I'd like to do it in a separate patch to
> > isolate possible revealing of hidden bugs... 
> > Actually, I'm thinking to kill this Item class in following patch(-es).
> 
> Sounds good. We usually add FIXMEs referencing bugs for future work.
True. Will add it before landing.

[Hajime Morrita]

Created attachment 141683 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 141683 [details]
Patch for landing

Rejecting attachment 141683 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12679475

[WebKit Review Bot]

Comment on attachment 141683 [details]
Patch for landing

Clearing flags on attachment: 141683

Committed r116974: <http://trac.webkit.org/changeset/116974>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.