Bug 86063 - Move resumeAnimations to use Internals interface
Summary: Move resumeAnimations to use Internals interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 00:21 PDT by Gyuyoung Kim
Modified: 2012-07-17 17:08 PDT (History)
5 users (show)

See Also:


Attachments
Patch (36.56 KB, patch)
2012-05-10 01:26 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (39.32 KB, patch)
2012-05-10 03:21 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-05-10 00:21:39 PDT
Adjust resumeAnimations() tests to use Internals instead of LayoutTestController interface. It seems to me that resumeAnimations() is able to be supported by Internals. Because, it looks this function is implemented by WebCore layer, not WebKit layer.
Comment 1 Gyuyoung Kim 2012-05-10 01:26:21 PDT
Created attachment 141106 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-10 02:10:55 PDT
Comment on attachment 141106 [details]
Patch

Attachment 141106 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12664261
Comment 3 Gyuyoung Kim 2012-05-10 03:21:05 PDT
Created attachment 141128 [details]
Patch
Comment 4 Alexey Proskuryakov 2012-05-10 11:50:54 PDT
Comment on attachment 141128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141128&action=review

> Source/WebKit/mac/WebKit.order:-1224
> --[WebFrame(WebPrivate) _resumeAnimations]

There is no need to update these order files. No harm either.

> Source/WebKit/mac/WebView/WebFramePrivate.h:-111
> -// Suspend and resume animations (includes both CSS transitions and CSS animations).
> -- (void)_resumeAnimations;

It's always scary to remove anything from *Private.h files - functions in these can be used by Apple software. I verified that this change is OK to the extent possible.
Comment 5 Gyuyoung Kim 2012-05-10 22:22:36 PDT
(In reply to comment #4)
> (From update of attachment 141128 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141128&action=review
> 
> > Source/WebKit/mac/WebKit.order:-1224
> > --[WebFrame(WebPrivate) _resumeAnimations]
> 
> There is no need to update these order files. No harm either.
> 
> > Source/WebKit/mac/WebView/WebFramePrivate.h:-111
> > -// Suspend and resume animations (includes both CSS transitions and CSS animations).
> > -- (void)_resumeAnimations;
> 
> It's always scary to remove anything from *Private.h files - functions in these can be used by Apple software. I verified that this change is OK to the extent possible.

I will take care it when submitting patch further. Thank you for your review.
Comment 6 WebKit Review Bot 2012-05-10 22:30:52 PDT
Comment on attachment 141128 [details]
Patch

Clearing flags on attachment: 141128

Committed r116729: <http://trac.webkit.org/changeset/116729>
Comment 7 WebKit Review Bot 2012-05-10 22:30:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Roger Fong 2012-07-17 17:08:06 PDT
This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes.