Bug 86063 – Move resumeAnimations to use Internals interface

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gyuyoung Kim]

Adjust resumeAnimations() tests to use Internals instead of LayoutTestController interface. It seems to me that resumeAnimations() is able to be supported by Internals. Because, it looks this function is implemented by WebCore layer, not WebKit layer.

[Gyuyoung Kim]

Created attachment 141106 [details]
Patch

[WebKit Review Bot]

Comment on attachment 141106 [details]
Patch

Attachment 141106 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12664261

[Gyuyoung Kim]

Created attachment 141128 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 141128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141128&action=review

> Source/WebKit/mac/WebKit.order:-1224
> --[WebFrame(WebPrivate) _resumeAnimations]

There is no need to update these order files. No harm either.

> Source/WebKit/mac/WebView/WebFramePrivate.h:-111
> -// Suspend and resume animations (includes both CSS transitions and CSS animations).
> -- (void)_resumeAnimations;

It's always scary to remove anything from *Private.h files - functions in these can be used by Apple software. I verified that this change is OK to the extent possible.

[Gyuyoung Kim]

(In reply to comment #4)
> (From update of attachment 141128 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141128&action=review
> 
> > Source/WebKit/mac/WebKit.order:-1224
> > --[WebFrame(WebPrivate) _resumeAnimations]
> 
> There is no need to update these order files. No harm either.
> 
> > Source/WebKit/mac/WebView/WebFramePrivate.h:-111
> > -// Suspend and resume animations (includes both CSS transitions and CSS animations).
> > -- (void)_resumeAnimations;
> 
> It's always scary to remove anything from *Private.h files - functions in these can be used by Apple software. I verified that this change is OK to the extent possible.

I will take care it when submitting patch further. Thank you for your review.

[WebKit Review Bot]

Comment on attachment 141128 [details]
Patch

Clearing flags on attachment: 141128

Committed r116729: <http://trac.webkit.org/changeset/116729>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Roger Fong]

This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes.