Bug 86047 - JIT memory allocator is not returning memory to the OS on Darwin
Summary: JIT memory allocator is not returning memory to the OS on Darwin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-09 17:39 PDT by Filip Pizlo
Modified: 2012-05-11 15:36 PDT (History)
1 user (show)

See Also:

Attachments
the patch (1.83 KB, patch)
2012-05-09 17:41 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
improvement (1.50 KB, patch)
2012-05-11 15:30 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-05-09 17:39:43 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-05-09 17:40:30 PDT 
<rdar://problem/11414948>
Comment 2 Filip Pizlo 2012-05-09 17:41:57 PDT 
Created attachment 141065 [details]
the patch
Comment 3 Geoffrey Garen 2012-05-09 17:43:25 PDT 
Comment on attachment 141065 [details]
the patch

r=me
Comment 4 WebKit Review Bot 2012-05-09 17:44:34 PDT 
Attachment 141065 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:93:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2012-05-09 18:32:44 PDT 
Landed with style fixes in http://trac.webkit.org/changeset/116593
Comment 6 Filip Pizlo 2012-05-11 15:29:42 PDT 
This cam be made a bit safer.  Will post an improvement patch shortly.
Comment 7 Filip Pizlo 2012-05-11 15:30:59 PDT 
Created attachment 141509 [details]
improvement
Comment 8 Geoffrey Garen 2012-05-11 15:33:22 PDT 
Comment on attachment 141509 [details]
improvement

r=me
Comment 9 Filip Pizlo 2012-05-11 15:36:35 PDT 
Additional fix landed in http://trac.webkit.org/changeset/116813