Bug 86046 - [Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions
Summary: [Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Thomas Sepez
Depends on:
Reported: 2012-05-09 17:28 PDT by Charles Reis
Modified: 2012-05-10 14:13 PDT (History)
3 users (show)

See Also:

Patch containing revised test. (2.93 KB, patch)
2012-05-10 11:20 PDT, Thomas Sepez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Reis 2012-05-09 17:28:04 PDT
The ChromePageNoJavascript test in Source/WebKit/chromium/tests/WebFrameTest.cpp is trying to verify that content injected into the DOM isn't showing up because it's a Chrome page.  However, the injected content currently wouldn't be detected even if Chrome URLs were allowed to run JavaScript.  There needs to be a webView->layout() call before calling contentsAsText in order to catch it.
Comment 1 Thomas Sepez 2012-05-10 11:20:19 PDT
Created attachment 141202 [details]
Patch containing revised test.
Comment 2 WebKit Review Bot 2012-05-10 14:13:29 PDT
Comment on attachment 141202 [details]
Patch containing revised test.

Clearing flags on attachment: 141202

Committed r116686: <http://trac.webkit.org/changeset/116686>
Comment 3 WebKit Review Bot 2012-05-10 14:13:34 PDT
All reviewed patches have been landed.  Closing bug.