Bug 86045 - [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
Summary: [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-05-09 17:19 PDT by Adam Barth
Modified: 2012-05-09 22:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2012-05-09 17:20 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-05-09 17:19:32 PDT 
[Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
Comment 1 Adam Barth 2012-05-09 17:20:53 PDT 
Created attachment 141062 [details]
Patch
Comment 2 Adam Barth 2012-05-09 17:21:18 PDT 
Another possibility is to add ENABLE macros to these files.
Comment 3 Eric Seidel (no email) 2012-05-09 17:22:20 PDT 
Comment on attachment 141062 [details]
Patch

OK.
Comment 4 WebKit Review Bot 2012-05-09 18:00:42 PDT 
Comment on attachment 141062 [details]
Patch

Clearing flags on attachment: 141062

Committed r116590: <http://trac.webkit.org/changeset/116590>
Comment 5 WebKit Review Bot 2012-05-09 18:00:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kent Tamura 2012-05-09 22:50:06 PDT 
(In reply to comment #4)
> (From update of attachment 141062 [details])
> Clearing flags on attachment: 141062
> 
> Committed r116590: <http://trac.webkit.org/changeset/116590>

This made a build error on Android.  I reverted the change.

/usr/local/google/b/webkit-slave/chromium-linux-android/build/Source/WebKit/chromium/android-ndk-r7b/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: out/Release/obj.target/DumpRenderTree/Tools/DumpRenderTree/chromium/WebViewHost.o: in function WebViewHost::userMediaClientMock():Tools/DumpRenderTree/chromium/WebViewHost.cpp:728: error: undefined reference to 'WebKit::WebUserMediaClientMock::create()'
Comment 7 Adam Barth 2012-05-09 22:54:35 PDT 
Thanks.
Comment 8 Adam Barth 2012-05-09 22:55:25 PDT 
We're going to need to do these GYP changes later.