WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86041
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
https://bugs.webkit.org/show_bug.cgi?id=86041
Summary
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT...
Adam Barth
Reported
2012-05-09 17:12:05 PDT
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
Attachments
Patch
(1.28 KB, patch)
2012-05-09 17:12 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-05-09 17:12:32 PDT
Created
attachment 141059
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-05-09 17:15:04 PDT
Comment on
attachment 141059
[details]
Patch Why?
Adam Barth
Comment 3
2012-05-09 17:36:10 PDT
Comment on
attachment 141059
[details]
Patch I'm not sure. One possibility to just to reduce the binary size of DRT. I found the patch in the downstream OS(ANDROID) repository and it seemed harmless to upstream.
WebKit Review Bot
Comment 4
2012-05-09 17:55:32 PDT
Comment on
attachment 141059
[details]
Patch Clearing flags on attachment: 141059 Committed
r116589
: <
http://trac.webkit.org/changeset/116589
>
WebKit Review Bot
Comment 5
2012-05-09 17:55:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug