Bug 86041 - [Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
: [Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Adam Barth
:
Depends on:
Blocks: 66687
  Show dependency treegraph
 
Reported: 2012-05-09 17:12 PDT by Adam Barth
Modified: 2012-05-09 17:55 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2012-05-09 17:12 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-05-09 17:12:05 PDT
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
Comment 1 Adam Barth 2012-05-09 17:12:32 PDT
Created attachment 141059 [details]
Patch
Comment 2 Eric Seidel 2012-05-09 17:15:04 PDT
Comment on attachment 141059 [details]
Patch

Why?
Comment 3 Adam Barth 2012-05-09 17:36:10 PDT
Comment on attachment 141059 [details]
Patch

I'm not sure.  One possibility to just to reduce the binary size of DRT.  I found the patch in the downstream OS(ANDROID) repository and it seemed harmless to upstream.
Comment 4 WebKit Review Bot 2012-05-09 17:55:32 PDT
Comment on attachment 141059 [details]
Patch

Clearing flags on attachment: 141059

Committed r116589: <http://trac.webkit.org/changeset/116589>
Comment 5 WebKit Review Bot 2012-05-09 17:55:38 PDT
All reviewed patches have been landed.  Closing bug.