Bug 86040 - [Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
Summary: [Chromium] Android needs to swizzle pixel dumps in order to get the same hash...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
: 84682 (view as bug list)
Depends on:
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-05-09 17:08 PDT by Adam Barth
Modified: 2012-05-09 17:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2012-05-09 17:08 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-05-09 17:08:23 PDT 
[Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
Comment 1 Adam Barth 2012-05-09 17:08:54 PDT 
Created attachment 141057 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-09 17:13:16 PDT 
Comment on attachment 141057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141057&action=review

> Tools/DumpRenderTree/chromium/TestShell.cpp:710
> +#if OS(ANDROID)
> +        webkit_support::EncodeRGBAPNGWithChecksum(reinterpret_cast<const unsigned char*>(sourceBitmap.getPixels()), sourceBitmap.width(),
> +            sourceBitmap.height(), static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, md5hash, &png);
> +#else
>          webkit_support::EncodeBGRAPNGWithChecksum(reinterpret_cast<const unsigned char*>(sourceBitmap.getPixels()), sourceBitmap.width(),
>              sourceBitmap.height(), static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, md5hash, &png);
> +#endif

Did you just add 5 lines of code, or 4 charaters or am blind?
Comment 3 Kent Tamura 2012-05-09 17:28:58 PDT 
Comment on attachment 141057 [details]
Patch

This bug looks a dupe of Bug 84682.  Anyway, the code is ok.
Comment 4 Adam Barth 2012-05-09 17:30:24 PDT 
*** Bug 84682 has been marked as a duplicate of this bug. ***
Comment 5 WebKit Review Bot 2012-05-09 17:50:30 PDT 
Comment on attachment 141057 [details]
Patch

Clearing flags on attachment: 141057

Committed r116588: <http://trac.webkit.org/changeset/116588>
Comment 6 WebKit Review Bot 2012-05-09 17:50:35 PDT 
All reviewed patches have been landed.  Closing bug.