Bug 86039 - [Cairo] GLContextGLX releases the context with an uninitialized display
Summary: [Cairo] GLContextGLX releases the context with an uninitialized display
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 17:06 PDT by Martin Robinson
Modified: 2012-05-09 17:34 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2012-05-09 17:09 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-05-09 17:06:23 PDT
Instead of using sharedDisplay() GLContextGLX releases the context with the m_display member which is uninitialized. This apparently doesn't cause an issue on most machines, but has the potential to create a nasty crash.
Comment 1 Martin Robinson 2012-05-09 17:09:38 PDT
Created attachment 141058 [details]
Patch
Comment 2 Philippe Normand 2012-05-09 17:14:21 PDT
Comment on attachment 141058 [details]
Patch

Good catch, Martin!
Comment 3 WebKit Review Bot 2012-05-09 17:34:02 PDT
Comment on attachment 141058 [details]
Patch

Clearing flags on attachment: 141058

Committed r116585: <http://trac.webkit.org/changeset/116585>
Comment 4 WebKit Review Bot 2012-05-09 17:34:06 PDT
All reviewed patches have been landed.  Closing bug.