Bug 86038 - REGRESSION(r116573): Broke the Chromium Mac compile (Requested by ojan_gardening on #webkit).
Summary: REGRESSION(r116573): Broke the Chromium Mac compile (Requested by ojan_garden...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
Depends on:
Blocks: 85916
  Show dependency treegraph
Reported: 2012-05-09 16:50 PDT by WebKit Review Bot
Modified: 2012-05-09 17:17 PDT (History)
3 users (show)

See Also:

ROLLOUT of r116573 (1.34 KB, patch)
2012-05-09 16:51 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-05-09 16:50:52 PDT
http://trac.webkit.org/changeset/116573 broke the build:
Broke the Chromium Mac compile (Requested by ojan_gardening on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-05-09 16:51:48 PDT
Created attachment 141051 [details]
ROLLOUT of r116573

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ojan Vafai 2012-05-09 16:53:07 PDT
In file included from webkit/plugins/webview_plugin.cc:5:
./webkit/plugins/webview_plugin.h:65:31: error: 'webkit::WebViewPlugin::container' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  WebKit::WebPluginContainer* container() { return container_; }
./third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h:59:33: note: hidden overloaded virtual function 'WebKit::WebPlugin::container' declared here
    virtual WebPluginContainer* container() const { return 0; }
1 error generated.
make: *** [out/Release/obj.target/glue/webkit/plugins/webview_plugin.o] Error 1
Comment 3 WebKit Review Bot 2012-05-09 17:17:38 PDT
Comment on attachment 141051 [details]
ROLLOUT of r116573

Clearing flags on attachment: 141051

Committed r116582: <http://trac.webkit.org/changeset/116582>
Comment 4 WebKit Review Bot 2012-05-09 17:17:42 PDT
All reviewed patches have been landed.  Closing bug.