Bug 86033 - Speed up some parts of TileCache drawing
Summary: Speed up some parts of TileCache drawing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 16:16 PDT by Anders Carlsson
Modified: 2012-05-09 17:11 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.84 KB, patch)
2012-05-09 16:19 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-05-09 16:16:59 PDT
Speed up some parts of TileCache drawing
Comment 1 Anders Carlsson 2012-05-09 16:19:10 PDT
Created attachment 141043 [details]
Patch
Comment 2 Sam Weinig 2012-05-09 17:06:18 PDT
Comment on attachment 141043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141043&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:278
> +    if (m_isInWindow && m_canHaveScrollbars) {

Can you add a comment here about why this predicate is right?  It might make sense to pull it out into a variable with a descriptive name.
Comment 3 Anders Carlsson 2012-05-09 17:11:56 PDT
Committed r116579: <http://trac.webkit.org/changeset/116579>