Bug 86028 - Don't append log lines while perf tests are running.
Summary: Don't append log lines while perf tests are running.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency treegraph
 
Reported: 2012-05-09 16:01 PDT by Tony Chang
Modified: 2012-05-14 12:28 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.40 KB, patch)
2012-05-09 16:03 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (2.36 KB, patch)
2012-05-14 10:00 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (2.34 KB, patch)
2012-05-14 11:53 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-05-09 16:01:11 PDT
Don't append log lines while perf tests are running.
Comment 1 Tony Chang 2012-05-09 16:03:26 PDT
Created attachment 141039 [details]
Patch
Comment 2 Tony Chang 2012-05-11 10:59:48 PDT
ping ryosuke
Comment 3 Ryosuke Niwa 2012-05-11 21:53:31 PDT
Comment on attachment 141039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review

We've started adding tests in http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/perftests not that I think we should add a test for this.

> PerformanceTests/resources/runner.js:171
> +    this._showLogLinesAtEndOfTest = !!window.layoutTestController;
> +    this._logLines = [];

We can just do:
this._logLines = window.layoutTestController ? [] : undefined;
That way, we don't need _showLogLinesAtEndOfTest.
Comment 4 Tony Chang 2012-05-14 10:00:46 PDT
Created attachment 141746 [details]
Patch for landing
Comment 5 Tony Chang 2012-05-14 10:01:20 PDT
(In reply to comment #3)
> (From update of attachment 141039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review
> 
> > PerformanceTests/resources/runner.js:171
> > +    this._showLogLinesAtEndOfTest = !!window.layoutTestController;
> > +    this._logLines = [];
> 
> We can just do:
> this._logLines = window.layoutTestController ? [] : undefined;
> That way, we don't need _showLogLinesAtEndOfTest.

Good idea, done.
Comment 6 Ryosuke Niwa 2012-05-14 11:05:06 PDT
Comment on attachment 141746 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=141746&action=review

> PerformanceTests/resources/runner.js:183
> +    this._logLines = window.layoutTestController ? [] : null;

Oh you probably need to do this in initAndStartLoop instead because now we have runPerSecond.
Comment 7 Tony Chang 2012-05-14 11:53:19 PDT
Created attachment 141763 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-05-14 12:28:04 PDT
Comment on attachment 141763 [details]
Patch for landing

Clearing flags on attachment: 141763

Committed r116984: <http://trac.webkit.org/changeset/116984>
Comment 9 WebKit Review Bot 2012-05-14 12:28:09 PDT
All reviewed patches have been landed.  Closing bug.