Don't append log lines while perf tests are running.

[Tony Chang]

Don't append log lines while perf tests are running.

[Tony Chang]

Created attachment 141039 [details]
Patch

[Tony Chang]

ping ryosuke

[Ryosuke Niwa]

Comment on attachment 141039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review

We've started adding tests in http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/perftests not that I think we should add a test for this.

> PerformanceTests/resources/runner.js:171
> +    this._showLogLinesAtEndOfTest = !!window.layoutTestController;
> +    this._logLines = [];

We can just do:
this._logLines = window.layoutTestController ? [] : undefined;
That way, we don't need _showLogLinesAtEndOfTest.

[Tony Chang]

Created attachment 141746 [details]
Patch for landing

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 141039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review
> 
> > PerformanceTests/resources/runner.js:171
> > +    this._showLogLinesAtEndOfTest = !!window.layoutTestController;
> > +    this._logLines = [];
> 
> We can just do:
> this._logLines = window.layoutTestController ? [] : undefined;
> That way, we don't need _showLogLinesAtEndOfTest.

Good idea, done.

[Ryosuke Niwa]

Comment on attachment 141746 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=141746&action=review

> PerformanceTests/resources/runner.js:183
> +    this._logLines = window.layoutTestController ? [] : null;

Oh you probably need to do this in initAndStartLoop instead because now we have runPerSecond.

[Tony Chang]

Created attachment 141763 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 141763 [details]
Patch for landing

Clearing flags on attachment: 141763

Committed r116984: <http://trac.webkit.org/changeset/116984>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.