Bug 86023 - echo-inspan.pl is missing a semicolon on line 14, freaks out Apache on multiple regression tests
Summary: echo-inspan.pl is missing a semicolon on line 14, freaks out Apache on multip...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 15:28 PDT by WebKit Review Bot
Modified: 2012-05-22 13:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2012-05-22 11:20 PDT, Adam Barth
eric: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-02 (528.65 KB, application/zip)
2012-05-22 11:49 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from ec2-cr-linux-04 (718.44 KB, application/zip)
2012-05-22 11:51 PDT, WebKit Review Bot
no flags Details
Patch and rebase tests (2.60 KB, patch)
2012-05-22 12:05 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch and rebased tests (2.77 KB, patch)
2012-05-22 12:07 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-05-09 15:28:33 PDT
echo-inspan.pl is missing a ; on like 14
Requested by abarth on #webkit.
Comment 1 Alexey Proskuryakov 2012-05-22 10:25:08 PDT
Are we losing a substantial amount of coverage due to this?
Comment 2 Adam Barth 2012-05-22 11:16:43 PDT
I'm not sure.  I've got a free working copy now, so I'll try to work up a patch.
Comment 3 Adam Barth 2012-05-22 11:20:13 PDT
Created attachment 143330 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-05-22 11:22:35 PDT
Comment on attachment 143330 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2012-05-22 11:49:45 PDT
Comment on attachment 143330 [details]
Patch

Rejecting attachment 143330 [details] from commit-queue.

New failing tests:
http/tests/security/xssAuditor/open-script-src.html
http/tests/security/xssAuditor/open-iframe-src.html
Full output: http://queues.webkit.org/results/12749394
Comment 6 WebKit Review Bot 2012-05-22 11:49:49 PDT
Created attachment 143340 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 WebKit Review Bot 2012-05-22 11:51:24 PDT
Comment on attachment 143330 [details]
Patch

Attachment 143330 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12760133

New failing tests:
http/tests/security/xssAuditor/open-script-src.html
http/tests/security/xssAuditor/open-iframe-src.html
Comment 8 WebKit Review Bot 2012-05-22 11:51:29 PDT
Created attachment 143341 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 9 Daniel Bates 2012-05-22 12:05:23 PDT
Created attachment 143344 [details]
Patch and rebase tests

Rebased test results for tests LayoutTests/http/tests/security/xssAuditor/{open-iframe-src, open-script-src}.html
Comment 10 Adam Barth 2012-05-22 12:06:28 PDT
dbates++
Comment 11 Daniel Bates 2012-05-22 12:07:52 PDT
Created attachment 143346 [details]
Patch and rebased tests
Comment 12 WebKit Review Bot 2012-05-22 13:53:19 PDT
Comment on attachment 143346 [details]
Patch and rebased tests

Clearing flags on attachment: 143346

Committed r118047: <http://trac.webkit.org/changeset/118047>
Comment 13 WebKit Review Bot 2012-05-22 13:53:25 PDT
All reviewed patches have been landed.  Closing bug.