Bug 86009 – Remove some isSVGFoo methods

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Rob Buis]

Stuff like isRounded() is not needed at all atm.

[Rob Buis]

Created attachment 141000 [details]
Patch

[Philip Rogers]

I would give this a R+ if I could.

[Eric Seidel (no email)]

Comment on attachment 141000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review

> Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42
> -    virtual bool isSVGEllipse() const { return true; }

Is there one of these on teh base class as well?

[Rob Buis]

Hi Eric,

Thanks for the review!

(In reply to comment #3)
> (From update of attachment 141000 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review
> 
> > Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42
> > -    virtual bool isSVGEllipse() const { return true; }
> 
> Is there one of these on teh base class as well?

Nope, there was a mention of isSVGRect in RenderObject.h but not isSVGEllipse, a sure sign that some of these flags got inconsistent.

[WebKit Review Bot]

Comment on attachment 141000 [details]
Patch

Clearing flags on attachment: 141000

Committed r116557: <http://trac.webkit.org/changeset/116557>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.