Bug 86009 - Remove some isSVGFoo methods
Summary: Remove some isSVGFoo methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 12:45 PDT by Rob Buis
Modified: 2012-05-09 14:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.25 KB, patch)
2012-05-09 12:49 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-05-09 12:45:02 PDT
Stuff like isRounded() is not needed at all atm.
Comment 1 Rob Buis 2012-05-09 12:49:58 PDT
Created attachment 141000 [details]
Patch
Comment 2 Philip Rogers 2012-05-09 13:06:30 PDT
I would give this a R+ if I could.
Comment 3 Eric Seidel (no email) 2012-05-09 13:18:06 PDT
Comment on attachment 141000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review

> Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42
> -    virtual bool isSVGEllipse() const { return true; }

Is there one of these on teh base class as well?
Comment 4 Rob Buis 2012-05-09 13:21:33 PDT
Hi Eric,

Thanks for the review!

(In reply to comment #3)
> (From update of attachment 141000 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review
> 
> > Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42
> > -    virtual bool isSVGEllipse() const { return true; }
> 
> Is there one of these on teh base class as well?

Nope, there was a mention of isSVGRect in RenderObject.h but not isSVGEllipse, a sure sign that some of these flags got inconsistent.
Comment 5 WebKit Review Bot 2012-05-09 14:19:25 PDT
Comment on attachment 141000 [details]
Patch

Clearing flags on attachment: 141000

Committed r116557: <http://trac.webkit.org/changeset/116557>
Comment 6 WebKit Review Bot 2012-05-09 14:19:30 PDT
All reviewed patches have been landed.  Closing bug.