Bug 85999 - [GTK] WK2 misses WebKitSettings for media playback requiring user gestures and inline playback
Summary: [GTK] WK2 misses WebKitSettings for media playback requiring user gestures an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 09:21 PDT by Simon Pena
Modified: 2012-05-10 09:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.90 KB, patch)
2012-05-09 10:40 PDT, Simon Pena
no flags Details | Formatted Diff | Diff
Patch (11.93 KB, patch)
2012-05-09 11:23 PDT, Simon Pena
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pena 2012-05-09 09:21:59 PDT
In the same way as bug #85194, WK2 misses WebKitSettings in order to support media playback requiring user gestures or inline playback.

The attached patch provides those settings, and updates TestWebKitSettings to cover the additions.
Comment 1 Simon Pena 2012-05-09 10:40:35 PDT
Created attachment 140973 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-09 10:43:27 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Review Bot 2012-05-09 11:10:20 PDT
Comment on attachment 140973 [details]
Patch

Rejecting attachment 140973 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12663061
Comment 4 Simon Pena 2012-05-09 11:23:21 PDT
Created attachment 140984 [details]
Patch
Comment 5 WebKit Review Bot 2012-05-10 09:37:29 PDT
Comment on attachment 140984 [details]
Patch

Clearing flags on attachment: 140984

Committed r116652: <http://trac.webkit.org/changeset/116652>
Comment 6 WebKit Review Bot 2012-05-10 09:37:34 PDT
All reviewed patches have been landed.  Closing bug.