RESOLVED FIXED 85986
Move suspendAnimations to use Internals interface 
https://bugs.webkit.org/show_bug.cgi?id=85986
Summary Move suspendAnimations to use Internals interface
Gyuyoung Kim
Reported 2012-05-09 05:33:51 PDT
Adjust suspendAnimations() tests to use Internals instead of LayoutTestController interface. It seems to me that suspendAnimations() is able to be supported by Internals. Because, it looks this function is implemented by WebCore layer, not WebKit layer. If this patch is valid, I'm going to submit a patch for resumeAnimations() as well.
Attachments
Patch (35.87 KB, patch)
2012-05-09 05:43 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (37.00 KB, patch)
2012-05-09 07:03 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-05-09 05:43:44 PDT
Created attachment 140927 [details] Patch
Build Bot
Comment 2 2012-05-09 06:10:40 PDT
Comment on attachment 140927 [details] Patch Attachment 140927 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12642907
Gyuyoung Kim
Comment 3 2012-05-09 07:03:43 PDT
Created attachment 140936 [details] Patch
Gyuyoung Kim
Comment 4 2012-05-09 21:34:37 PDT
CC'ing Ryosuke, Alexey
WebKit Review Bot
Comment 5 2012-05-09 23:10:43 PDT
Comment on attachment 140936 [details] Patch Clearing flags on attachment: 140936 Committed r116610: <http://trac.webkit.org/changeset/116610>
WebKit Review Bot
Comment 6 2012-05-09 23:10:54 PDT
All reviewed patches have been landed. Closing bug.
Roger Fong
Comment 7 2012-07-17 17:07:32 PDT
This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes.
Ryosuke Niwa
Comment 8 2012-07-17 18:23:07 PDT
(In reply to comment #7) > This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes. Could you add a message rule on Source/WebKit/win/WebFrame.h to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/watchlist ? e.g. see AppleMacPublicApi http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/watchlist#L262 It wasn't obvious that this was a part of public API.
Gyuyoung Kim
Comment 9 2012-07-17 19:54:30 PDT
(In reply to comment #7) > This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes. There was similar problem in Bug 86704. I have tried to be more careful since the bug. Sorry for making inconvenience.
Note You need to log in before you can comment on or make changes to this bug.