Bug 85978 - [Forms] Move step related methods to InputType class from HTMLInputElement class
Summary: [Forms] Move step related methods to InputType class from HTMLInputElement class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 82034
  Show dependency tree / graph
 
Reported: 2012-05-09 03:44 PDT by yosin
Modified: 2012-05-10 00:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch 1 (24.25 KB, patch)
2012-05-09 03:46 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (25.34 KB, patch)
2012-05-09 20:53 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (24.66 KB, patch)
2012-05-09 21:54 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-05-09 03:44:01 PDT 
This is part of re-factoring of HTMLInputElement class for Steppable input type.

getAllowedValueStep and stepDown/stepUp/stepUpFromRendere methods of HTMLInputElement are used only by DateTime/Number/Range input type. For ease of maintenance, e.g. change of implementation should not change HTMLInputElement.cpp for reducing merge conflict, these method should be in files of input type implementation.
Comment 1 yosin 2012-05-09 03:46:34 PDT 
Created attachment 140905 [details]
Patch 1
Comment 2 Kent Tamura 2012-05-09 20:32:44 PDT 
Comment on attachment 140905 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=140905&action=review

> Source/WebCore/html/InputType.cpp:789
> +void InputType::applyStep(double count, AnyStepHandling anyStepHandling, TextFieldEventBehavior eventBehavior, ExceptionCode& ec)

The code you copied was written by
Google employees in 2009, 2010, 2011, 2012, and
Apple employees in 2011.

You need to update the copyright notice of this file.
Comment 3 yosin 2012-05-09 20:53:53 PDT 
Created attachment 141077 [details]
Patch 2
Comment 4 Kent Tamura 2012-05-09 21:00:28 PDT 
Comment on attachment 141077 [details]
Patch 2

Looks good
Comment 5 WebKit Review Bot 2012-05-09 21:03:33 PDT 
Comment on attachment 141077 [details]
Patch 2

Attachment 141077 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12656866
Comment 6 yosin 2012-05-09 21:54:17 PDT 
Created attachment 141084 [details]
Patch 3
Comment 7 yosin 2012-05-09 23:10:21 PDT 
Comment on attachment 141084 [details]
Patch 3

Sorry, previous patch contains wrong thing in HTMLInputElement.cpp. I failed to rebase then removing some newly added methods, isWeekField and so on.

Failure of CR-Linux-EWS isn't related to this patch, TIMEOUT, and unrelated tests.
Comment 8 WebKit Review Bot 2012-05-10 00:21:49 PDT 
Comment on attachment 141084 [details]
Patch 3

Clearing flags on attachment: 141084

Committed r116615: <http://trac.webkit.org/changeset/116615>
Comment 9 WebKit Review Bot 2012-05-10 00:22:01 PDT 
All reviewed patches have been landed.  Closing bug.