Bug 85978 – [Forms] Move step related methods to InputType class from HTMLInputElement class

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

This is part of re-factoring of HTMLInputElement class for Steppable input type.

getAllowedValueStep and stepDown/stepUp/stepUpFromRendere methods of HTMLInputElement are used only by DateTime/Number/Range input type. For ease of maintenance, e.g. change of implementation should not change HTMLInputElement.cpp for reducing merge conflict, these method should be in files of input type implementation.

Created attachment 140905 [details]
Patch 1

[Kent Tamura]

Comment on attachment 140905 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=140905&action=review

> Source/WebCore/html/InputType.cpp:789
> +void InputType::applyStep(double count, AnyStepHandling anyStepHandling, TextFieldEventBehavior eventBehavior, ExceptionCode& ec)

The code you copied was written by
Google employees in 2009, 2010, 2011, 2012, and
Apple employees in 2011.

You need to update the copyright notice of this file.

Created attachment 141077 [details]
Patch 2

[Kent Tamura]

Comment on attachment 141077 [details]
Patch 2

Looks good

[WebKit Review Bot]

Comment on attachment 141077 [details]
Patch 2

Attachment 141077 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12656866

Created attachment 141084 [details]
Patch 3

Comment on attachment 141084 [details]
Patch 3

Sorry, previous patch contains wrong thing in HTMLInputElement.cpp. I failed to rebase then removing some newly added methods, isWeekField and so on.

Failure of CR-Linux-EWS isn't related to this patch, TIMEOUT, and unrelated tests.

[WebKit Review Bot]

Comment on attachment 141084 [details]
Patch 3

Clearing flags on attachment: 141084

Committed r116615: <http://trac.webkit.org/changeset/116615>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.