RESOLVED FIXED 85976
[chromium] Exposes OrientationChangeEvent. 
https://bugs.webkit.org/show_bug.cgi?id=85976
Summary [chromium] Exposes OrientationChangeEvent.
Marcus Bulach
Reported 2012-05-09 03:40:59 PDT
[chromium] Exposes OrientationChangeEvent.
Attachments
Patch (2.97 KB, patch)
2012-05-09 03:46 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Patch (3.18 KB, patch)
2012-05-09 09:34 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marcus Bulach
Comment 1 2012-05-09 03:46:47 PDT
Created attachment 140906 [details] Patch
WebKit Review Bot
Comment 2 2012-05-09 03:49:59 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-05-09 08:58:30 PDT
Comment on attachment 140906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140906&action=review > Source/WebKit/chromium/public/WebFrame.h:570 > + virtual void sendOrientationChangeEvent(int orientation) = 0; This comment from Frame.h was helpful to me. I wonder if we should include it here too: // Orientation is the interface orientation in degrees. Some examples are: // 0 is straight up; -90 is when the device is rotated 90 clockwise; // 90 is when rotated counter clockwise.
Marcus Bulach
Comment 4 2012-05-09 09:34:31 PDT
Created attachment 140960 [details] Patch
Adam Barth
Comment 5 2012-05-09 09:35:00 PDT
Comment on attachment 140960 [details] Patch Many thanks.
Marcus Bulach
Comment 6 2012-05-09 09:35:02 PDT
Comment on attachment 140906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140906&action=review >> Source/WebKit/chromium/public/WebFrame.h:570 >> + virtual void sendOrientationChangeEvent(int orientation) = 0; > > This comment from Frame.h was helpful to me. I wonder if we should include it here too: > > // Orientation is the interface orientation in degrees. Some examples are: > // 0 is straight up; -90 is when the device is rotated 90 clockwise; > // 90 is when rotated counter clockwise. yeah, agreed it clarifies. added.
WebKit Review Bot
Comment 7 2012-05-09 10:58:09 PDT
Comment on attachment 140960 [details] Patch Clearing flags on attachment: 140960 Committed r116544: <http://trac.webkit.org/changeset/116544>
WebKit Review Bot
Comment 8 2012-05-09 10:58:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.