RESOLVED FIXED Bug 85975
Improve a warning message for a reftest having an unused expectation file. 
https://bugs.webkit.org/show_bug.cgi?id=85975
Summary Improve a warning message for a reftest having an unused expectation file.
Hayato Ito
Reported 2012-05-09 03:28:02 PDT
The current warning message is not intuitive. It might be better to update the message.
Attachments
Improve a warning message. (1.76 KB, patch)
2012-05-09 03:31 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-05-09 03:31:07 PDT
Created attachment 140904 [details] Improve a warning message.
Dirk Pranke
Comment 2 2012-05-09 12:28:24 PDT
Comment on attachment 140904 [details] Improve a warning message. This might be bikeshedding, but "expectation file" == test_expectations.txt to me. I'd probably call it a "expected baseline"
Ojan Vafai
Comment 3 2012-05-09 14:03:11 PDT
(In reply to comment #2) > (From update of attachment 140904 [details]) > This might be bikeshedding, but "expectation file" == test_expectations.txt to me. I'd probably call it a "expected baseline" Not really true historically for WebKit though. baseline is a chromium-ism that we've leaked in, so now it's a mess where people use the terms interchangeably.
Hayato Ito
Comment 4 2012-05-09 18:46:17 PDT
Thank you for comments, guys. Let me land this patch as is anyway. If term of 'expectation file' causes confusion, I'm happy to modify it later. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 140904 [details] [details]) > > This might be bikeshedding, but "expectation file" == test_expectations.txt to me. I'd probably call it a "expected baseline" > > Not really true historically for WebKit though. baseline is a chromium-ism that we've leaked in, so now it's a mess where people use the terms interchangeably.
WebKit Review Bot
Comment 5 2012-05-09 20:24:00 PDT
Comment on attachment 140904 [details] Improve a warning message. Clearing flags on attachment: 140904 Committed r116600: <http://trac.webkit.org/changeset/116600>
WebKit Review Bot
Comment 6 2012-05-09 20:24:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.