Bug 85955 – Coding style issues present in RenderFrameSet.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mario Sanchez Prada]

There are some coding style issues here that might be interesting to fix:

$ check-webkit-style Source/WebCore/rendering/RenderFrameSet.cpp
Source/WebCore/rendering/RenderFrameSet.cpp:184:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderFrameSet.cpp:186:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderFrameSet.cpp:349:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebCore/rendering/RenderFrameSet.cpp:687:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 1 files

[Mario Sanchez Prada]

Created attachment 140865 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 140865 [details]
Patch

OK.  I think there are mixed feelings about such clean-up only patches.

[Mario Sanchez Prada]

(In reply to comment #2)
> (From update of attachment 140865 [details])
> OK.  I think there are mixed feelings about such clean-up only patches.

Yeah, I understand. Just trying to showcase how the workflow for working with bugzilla is to some people.

Thanks for the fast response anyway!

[Mario Sanchez Prada]

Comment on attachment 140865 [details]
Patch

I will prefer to do it myself for better showcasing.

[Mario Sanchez Prada]

Committed r116496: <http://trac.webkit.org/changeset/116496>