Bug 85938 - [BlackBerry] Refactor data scheme support
Summary: [BlackBerry] Refactor data scheme support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-08 18:03 PDT by Charles Wei
Modified: 2012-06-01 02:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.12 KB, patch)
2012-05-09 04:38 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
final patch for landing (12.01 KB, patch)
2012-05-09 17:47 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-05-08 18:03:32 PDT 
Data scheme support is now implemented in NetworkJob.cpp,  but NetworkJob.cpp is not re-useable by Download, because NetworkJob.cpp is supposed to feed the data to webkit only. 

So we need to refractor the data scheme support,  move the data scheme out of NetworkJob to it's own stream, DataStream,  which can be wrapped up by both NetworkJob and Download Jobs.

Internal PR: 154804
Comment 1 Charles Wei 2012-05-09 04:38:58 PDT 
Created attachment 140914 [details]
Patch
Comment 2 Charles Wei 2012-05-09 04:40:33 PDT 
Above patch was internally reviewed by Joe Mason, Lyon Chen, Jason Liu and Mary
Comment 3 Rob Buis 2012-05-09 10:57:03 PDT 
Comment on attachment 140914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140914&action=review

LGTM.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-90
> -    out.resize(dst - out.data());

Is there anything more you can remove because this gets removed? Maybe #include <wtf/ASCIICType.h> ?
Comment 4 Charles Wei 2012-05-09 17:47:10 PDT 
Created attachment 141066 [details]
final patch for landing

Landing the patch after fixing minor comments from the reviewer.
Comment 5 WebKit Review Bot 2012-05-09 18:12:51 PDT 
Comment on attachment 141066 [details]
final patch for landing

Clearing flags on attachment: 141066

Committed r116591: <http://trac.webkit.org/changeset/116591>
Comment 6 Charles Wei 2012-06-01 02:39:35 PDT 
Patch has landed.  Mark it as Resolved.