Bug 85931 - [GTK] don't use soup_session_pause_message in webkitdownload
Summary: [GTK] don't use soup_session_pause_message in webkitdownload
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-05-08 16:46 PDT by Dan Winship
Modified: 2012-05-09 08:22 PDT (History)
1 user (show)

See Also:

patch (2.49 KB, patch)
2012-05-08 16:48 PDT, Dan Winship
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Winship 2012-05-08 16:46:05 PDT
related to bug 85159; libsoup master doesn't like it when you mix soup_session_pause_message() and SoupRequest.

I am not sure that this patch is totally right, since epiphany doesn't seem to ever show a dialog here, so you wouldn't really be able to tell if it was paused or not. It does make the warnings go away though...

It seems like this is something that there ought to be a test case for ("when following a link that should cause a download, the download gets paused until the higher levels decide what to do with it"), but I think that would require new DRT hooks?
Comment 1 Dan Winship 2012-05-08 16:48:58 PDT
Created attachment 140815 [details]

Hm... prepare-ChangeLog didn't add the "No new tests. (OOPS!)" line... I guess we get a pass because it's platform-specific code? Still, a test would be nice.
Comment 2 Martin Robinson 2012-05-08 16:51:12 PDT
Comment on attachment 140815 [details]

Looks good to me. setDefersLoading is tested by the layout tests, but an option if you want to add a test is to add a GTK+ API unit test.
Comment 3 Dan Winship 2012-05-09 04:54:57 PDT
Comment on attachment 140815 [details]

ok, actually testmimehandling was already broken against libsoup master without this patch, and now works again with this patch
Comment 4 WebKit Review Bot 2012-05-09 08:22:37 PDT
Comment on attachment 140815 [details]

Clearing flags on attachment: 140815

Committed r116525: <http://trac.webkit.org/changeset/116525>
Comment 5 WebKit Review Bot 2012-05-09 08:22:41 PDT
All reviewed patches have been landed.  Closing bug.