RESOLVED FIXED 85931
[GTK] don't use soup_session_pause_message in webkitdownload 
https://bugs.webkit.org/show_bug.cgi?id=85931
Summary [GTK] don't use soup_session_pause_message in webkitdownload
Dan Winship
Reported 2012-05-08 16:46:05 PDT
related to bug 85159; libsoup master doesn't like it when you mix soup_session_pause_message() and SoupRequest. I am not sure that this patch is totally right, since epiphany doesn't seem to ever show a dialog here, so you wouldn't really be able to tell if it was paused or not. It does make the warnings go away though... It seems like this is something that there ought to be a test case for ("when following a link that should cause a download, the download gets paused until the higher levels decide what to do with it"), but I think that would require new DRT hooks?
Attachments
patch (2.49 KB, patch)
2012-05-08 16:48 PDT, Dan Winship 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dan Winship
Comment 1 2012-05-08 16:48:58 PDT
Created attachment 140815 [details] patch Hm... prepare-ChangeLog didn't add the "No new tests. (OOPS!)" line... I guess we get a pass because it's platform-specific code? Still, a test would be nice.
Martin Robinson
Comment 2 2012-05-08 16:51:12 PDT
Comment on attachment 140815 [details] patch Looks good to me. setDefersLoading is tested by the layout tests, but an option if you want to add a test is to add a GTK+ API unit test.
Dan Winship
Comment 3 2012-05-09 04:54:57 PDT
Comment on attachment 140815 [details] patch ok, actually testmimehandling was already broken against libsoup master without this patch, and now works again with this patch
WebKit Review Bot
Comment 4 2012-05-09 08:22:37 PDT
Comment on attachment 140815 [details] patch Clearing flags on attachment: 140815 Committed r116525: <http://trac.webkit.org/changeset/116525>
WebKit Review Bot
Comment 5 2012-05-09 08:22:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.