Bug 85928 - [JSC] Regression: addEventListener() and removeEventListener() raise an exception on missing args
Summary: [JSC] Regression: addEventListener() and removeEventListener() raise an excep...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-08 16:24 PDT by Benjamin Poulain
Modified: 2012-05-08 20:24 PDT (History)
6 users (show)

See Also:


Attachments
Patch (10.42 KB, patch)
2012-05-08 16:39 PDT, Benjamin Poulain
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-05-08 16:24:47 PDT
addEventListener() and removeEventListener() raise an exception on missing args following:
-https://bugs.webkit.org/show_bug.cgi?id=62750
-https://bugs.webkit.org/show_bug.cgi?id=71489
-https://bugs.webkit.org/show_bug.cgi?id=71503

This breaks content.
Comment 1 Benjamin Poulain 2012-05-08 16:39:00 PDT
Created attachment 140812 [details]
Patch
Comment 2 Geoffrey Garen 2012-05-08 16:40:25 PDT
Comment on attachment 140812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140812&action=review

r=me

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2122
> +                    # For compatibility with legacy content, the EventListener call are generated without GenerateArgumentsCountCheck.

Typo: should be "calls".
Comment 3 Benjamin Poulain 2012-05-08 20:19:30 PDT
Committed r116486: <http://trac.webkit.org/changeset/116486>
Comment 4 Benjamin Poulain 2012-05-08 20:24:51 PDT
<rdar://problem/11092785>