Bug 85927 - [chromium] Reflections with masks should not occlude
Summary: [chromium] Reflections with masks should not occlude
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-08 15:54 PDT by Dana Jansens
Modified: 2012-05-08 17:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.87 KB, patch)
2012-05-08 15:59 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch for landing (11.00 KB, patch)
2012-05-08 16:39 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-05-08 15:54:28 PDT 
[chromium] Reflections with masks should not occlude
Comment 2 Dana Jansens 2012-05-08 15:59:02 PDT 
Created attachment 140804 [details]
Patch
Comment 3 James Robinson 2012-05-08 16:24:16 PDT 
Comment on attachment 140804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140804&action=review

> Source/WebCore/ChangeLog:16
> +        allow us to remove a F*XME from CCOT::finishedTargetRenderSurface().

F*XME?

could you expand out CCOT here, please? it's not necessarily obvious to a reader how this acronym should expand. you can also put this comment in the per-file or per-function information below so the context is obvious
Comment 4 Dana Jansens 2012-05-08 16:37:45 PDT 
(In reply to comment #3)
> (From update of attachment 140804 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140804&action=review
> 
> > Source/WebCore/ChangeLog:16
> > +        allow us to remove a F*XME from CCOT::finishedTargetRenderSurface().
> 
> F*XME?
> 
> could you expand out CCOT here, please? it's not necessarily obvious to a reader how this acronym should expand. you can also put this comment in the per-file or per-function information below so the context is obvious

Oops, yes, too much coffee.

Thanks.
Comment 5 Dana Jansens 2012-05-08 16:39:36 PDT 
Created attachment 140813 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-05-08 17:54:02 PDT 
Comment on attachment 140813 [details]
Patch for landing

Clearing flags on attachment: 140813

Committed r116472: <http://trac.webkit.org/changeset/116472>
Comment 7 WebKit Review Bot 2012-05-08 17:54:06 PDT 
All reviewed patches have been landed.  Closing bug.