WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
85915
Rename offsetTopLeft in RenderBoxModelObject to something better
https://bugs.webkit.org/show_bug.cgi?id=85915
Summary
Rename offsetTopLeft in RenderBoxModelObject to something better
Shezan Baig
Reported
2012-05-08 14:18:48 PDT
(from
bug 34875, comment 21
) I'm open to suggestions
Attachments
Patch
(5.91 KB, patch)
2012-05-10 08:23 PDT
,
Shezan Baig
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2012-05-08 15:36:50 PDT
Here’s the recipe for coming up with a good name: Write out a sentence or sentences describing what the function does or when it should be called. Then you can often select the name from the words in those sentences.
Shezan Baig
Comment 2
2012-05-10 08:23:26 PDT
Created
attachment 141176
[details]
Patch
Julien Chaffraix
Comment 3
2012-05-30 08:42:14 PDT
Comment on
attachment 141176
[details]
Patch Darin ping! This patch has been around for some time. The naming is fine by me, but I wasn't the one requesting this change. If there is no update, I am going to r+ it as a such a simple renaming shouldn't be waiting on reviewers.
Darin Adler
Comment 4
2012-05-30 12:47:46 PDT
Comment on
attachment 141176
[details]
Patch Name is kinda long, but I think it’s an improvement.
WebKit Review Bot
Comment 5
2012-05-30 13:31:07 PDT
Comment on
attachment 141176
[details]
Patch Clearing flags on attachment: 141176 Committed
r118961
: <
http://trac.webkit.org/changeset/118961
>
WebKit Review Bot
Comment 6
2012-05-30 13:31:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug