Bug 85906 - [Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad from QQuickWebViewPrivate
Summary: [Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad fr...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Depends on:
Reported: 2012-05-08 12:15 PDT by zalan
Modified: 2012-05-09 01:41 PDT (History)
6 users (show)

See Also:

Patch (4.95 KB, patch)
2012-05-08 12:31 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2012-05-08 12:15:55 PDT
No need to delay loading related activities, after http://trac.webkit.org/changeset/113172 , when WebView started being inherited from Flickable.

copied the discussion from here https://bugs.webkit.org/show_bug.cgi?id=84527#c3

"> (case 3, loadDidSucceed() implements some deferred loading success dispatching due to the delayed interaction engine construction. I looked at the original patch (bug 77111) and don't see any reasoning why success() is special in that case, and for example failed() is not. Commit log also states that page is suspended while I don't think it is, it's just that the suspend flag is turned on by default, so not sure why success() is treated differently here, unless I miss something, which could very well be the case. If this delaying logic could be omitted, we would end up even less d_func() calls in QtWebPageLoadClient(), provided that's the preferred direction.)

This delay was needed before the WebView became a subclass of Flickable because the instantiation of the internal Flickable happened in onComponentComplete and we needed to defer the emission of the success signal after the construction finished to prevent crashes in API tests, since almost all the unit tests depend on loadSuccess.

This delay can be omitted since WebView is a direct subclass of Flickable now."
Comment 1 zalan 2012-05-08 12:31:12 PDT
Created attachment 140766 [details]
Comment 2 WebKit Review Bot 2012-05-09 01:41:30 PDT
Comment on attachment 140766 [details]

Clearing flags on attachment: 140766

Committed r116505: <http://trac.webkit.org/changeset/116505>
Comment 3 WebKit Review Bot 2012-05-09 01:41:35 PDT
All reviewed patches have been landed.  Closing bug.