Bug 85903 – Show the chromium non-layout test bots in garden-o-matic

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

Show the chromium non-layout test bots in garden-o-matic

[Ojan Vafai]

Created attachment 140755 [details]
Patch

[Ojan Vafai]

Created attachment 140756 [details]
screenshot

[Eric Seidel (no email)]

Comment on attachment 140755 [details]
Patch

Seems reasonable to me.  Adam is your best reviewer of course.

[Adam Barth]

I like the approach of iframing buildbot.  The label text seems a bit long, but maybe that's just because the screen shot is narrow?

Another approach is to just list the names of the bots when they fail (like we do for compile failures).  The gtest bots should already be in the JSON blob we fetch from the server, so it might just be a matter of grabbing the information out of there.

That said, if you the green/red approach better, that's fine too.  :)

[Ojan Vafai]

(In reply to comment #4)
> I like the approach of iframing buildbot.  The label text seems a bit long, but maybe that's just because the screen shot is narrow?

I think it's just the screenshot being narrow.

> Another approach is to just list the names of the bots when they fail (like we do for compile failures).  The gtest bots should already be in the JSON blob we fetch from the server, so it might just be a matter of grabbing the information out of there.
> 
> That said, if you the green/red approach better, that's fine too.  :)

We could do that. I just did this because it was easy and visual. Text is more likely to get overlooked. I'll leave it like this for now, but if it bugs you, we can change it.

[Ojan Vafai]

(In reply to comment #4)
> Another approach is to just list the names of the bots when they fail (like we do for compile failures).

Do we do this for compile failures? The Mac bots are not compiling right now and I don't see anything in garden-o-matic (as a result I missed this for a couple of hours!).

[Adam Barth]

> Do we do this for compile failures? The Mac bots are not compiling right now and I don't see anything in garden-o-matic (as a result I missed this for a couple of hours!).

It should say something about "losing test coverage" near the top.

[Ojan Vafai]

(In reply to comment #7)
> > Do we do this for compile failures? The Mac bots are not compiling right now and I don't see anything in garden-o-matic (as a result I missed this for a couple of hours!).
> 
> It should say something about "losing test coverage" near the top.

Nope. Nothing. Looks like this broke at some point.

[WebKit Review Bot]

Comment on attachment 140755 [details]
Patch

Clearing flags on attachment: 140755

Committed r116483: <http://trac.webkit.org/changeset/116483>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.